Skip to content

[Rename] Bump submodule + regenerate catalogs + fix drift CI [Epic 2/4] #191

@ProfessorPolymorphic

Description

@ProfessorPolymorphic

Part of #189. Blocks on slice 1.

Goal

After the upstream data-governance rename PR lands (slice 1), bump the vendor/data-governance/ submodule pointer in this repo, regenerate lib/governance/{catalog,vocabularies}.ts, and update any consumer that still references InterventionStatus so the build and drift CI stay green.

Why

The auto-generated governance catalog files (CLAUDE.md rule 13) flip from referencing InterventionStatus to ProjectStatus as soon as the submodule is bumped. Anything that imports or string-matches against the old name breaks immediately. This slice catches that in one coordinated pass.

Scope

Files touched:

  • vendor/data-governance/ — submodule pointer bump (git submodule update --remote).
  • lib/governance/catalog.ts — auto-regenerated by npm run build:governance.
  • lib/governance/vocabularies.ts — auto-regenerated by npm run build:governance.
  • scripts/verify-portfolio.ts and lib/portfolio-verification.ts — search for InterventionStatus / Intervention string references; rename.
  • scripts/refresh-commit-dates.ts — same sweep.
  • lib/lifecycle-display.ts — same sweep.
  • lib/portfolio-meta.ts — auto-generated; will regen on next npm run build.
  • Drift CI script (scripts/governance-drift.* if present locally; check .github/workflows/governance-drift.yml).
  • Governance PR-summary script (scripts/governance-pr-summary.ts) — string match if any.

Acceptance

  • npm run build:governance runs clean; output references ProjectStatus.
  • npm run build clean.
  • npm run verify:portfolio clean.
  • Governance Drift CI green on this PR.
  • Governance PR Summary posts a coherent diff (vocabulary group renamed should appear cleanly in the summary).
  • No string InterventionStatus remains in the AISPEG repo (grep -r 'InterventionStatus' . returns nothing outside of historical git log).

Out of scope

  • Component/type/file renames (InterventionDetail.tsxProjectDetail.tsx) — slice 3.
  • User-facing copy and docs sweep — slice 4.

Sequencing note

This PR should be opened immediately after slice 1's upstream PR merges. The window where AISPEG's pinned submodule SHA is older than upstream causes drift CI to fail on every unrelated open PR. Land in one sitting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions