I would argue that adding a crond service resource (in response to #7) to this module may not be the best the best thing.
You should/could either...
A) make it controlled via parameter
B) at least attempt to see if has been defined somewhere and not maybe not manage it here if so, using the "defined()" parser function
Personally, I think this is best handled with roles/profiles, allowing the dependency to be defined at that level if needed. Right now, with that cron resource, this module is managing resources that belong to another technology (cron). That makes it potentially hard to use some other module that explicitly is about managing cron for example.
Just some food for thought, perhaps a refactor should come from this. Otherwise awesome and well thought out module, thanks!
I would argue that adding a crond service resource (in response to #7) to this module may not be the best the best thing.
You should/could either...
A) make it controlled via parameter
B) at least attempt to see if has been defined somewhere and not maybe not manage it here if so, using the "defined()" parser function
Personally, I think this is best handled with roles/profiles, allowing the dependency to be defined at that level if needed. Right now, with that cron resource, this module is managing resources that belong to another technology (cron). That makes it potentially hard to use some other module that explicitly is about managing cron for example.
Just some food for thought, perhaps a refactor should come from this. Otherwise awesome and well thought out module, thanks!