Problem
PRs #56 and #59 both define a findRepoRoot helper function in internal/agentkit/agentkit_test.go with incompatible signatures:
Merging both will cause a compile error.
Resolution
Establish merge order: #56 merges first (introduces findRepoRoot(t *testing.T) string), then #59 rebases and adopts the existing function.
The (t *testing.T) string signature is preferred — it's idiomatic for test helpers (uses t.Helper() + t.Fatalf internally).
Context
Identified by review council run on 2026-08-10 across the DCP prompt hardening PR series (#54-#59).
Recommended merge order: #54 (merged) → #55 → #57 → #56 → #59
Problem
PRs #56 and #59 both define a
findRepoRoothelper function ininternal/agentkit/agentkit_test.gowith incompatible signatures:func findRepoRoot(t *testing.T) stringfunc findRepoRoot() (string, error)Merging both will cause a compile error.
Resolution
Establish merge order: #56 merges first (introduces
findRepoRoot(t *testing.T) string), then #59 rebases and adopts the existing function.The
(t *testing.T) stringsignature is preferred — it's idiomatic for test helpers (usest.Helper()+t.Fatalfinternally).Context
Identified by review council run on 2026-08-10 across the DCP prompt hardening PR series (#54-#59).
Recommended merge order: #54 (merged) → #55 → #57 → #56 → #59