Skip to content

docs: The Adversary gains a Concurrency Correctness review checklist #269

Description

@yvonnedevlinrh

What changed

divisor-adversary.md (The Adversary agent persona) gained a new Concurrency Correctness checklist section within its Security & Resilience domain, scoped to production code. Five auditable review items: goroutine leaks/cancellation, deadlock & lock-ordering/channel blocking, unsafe concurrent map/slice/shared access, missing context.Context propagation, and sync.WaitGroup misuse. Adds an Adversary/SRE Out of Scope boundary row (concurrency correctness → Adversary; concurrency efficiency → SRE); test-code concurrency remains with The Tester. Change is mirrored into the embedded scaffold asset.

Why it matters (user-facing)

Teams reading hero capability docs need the updated Adversary scope and the Adversary/SRE/Tester concurrency ownership boundary.

Pages likely needing updates

  • unbound-force/website: The Adversary (Divisor) capability page
  • Any Divisor scope-boundary / "who owns what" matrix
  • docs/heroes.md (~line 145): add concurrency correctness to Adversary
  • docs/architecture.md (~line 510): assess Adversary focus-area row
  • Adversary scope tables in .opencode/commands/uf.review-council.md
    (~line 161) and uf.triage-issue.md (~line 152)

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions