feat: Add django-guardin permissions#237
Draft
dsowinski2 wants to merge 1 commit into
Draft
Conversation
dsowinski2
changed the title
dsowinski2
force-pushed
the
feat/create-limited-admin-permission
branch
from
d80ad7e to
41dca02
Compare
dsowinski2
changed the base branch from
feat/add-otp-login
to
feat/add-sso-layer
dsowinski2
force-pushed
the
feat/create-limited-admin-permission
branch
from
41dca02 to
2b19782
Compare
dsowinski2
force-pushed
the
feat/add-sso-layer
branch
from
5b203e1 to
791f5a9
Compare
dsowinski2
force-pushed
the
feat/create-limited-admin-permission
branch
from
2b19782 to
47bc04f
Compare
dsowinski2
force-pushed
the
feat/create-limited-admin-permission
branch
from
47bc04f to
cd67a31
Compare
dsowinski2
force-pushed
the
feat/create-limited-admin-permission
branch
from
cd67a31 to
9a9b106
Compare
dsowinski2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds django-guardian. It's beginning of permissions and roles refactor.
Purpose of this refactor is to have a way to control endpoints access in starter repos.
Current implementation is not easily extendable.
Django Guardian will let to assign global and per object permissions making it easier to work with e.g. datasets, and leaving space for more granular permissions in future.
In this PR introduces change for user and dataset related endpoints.
It still need a way to e.g. define other roles, pointing to specific user service.
SSO layer will work without this but starters won't have a way to define new user permissions easily.