From 8c19a1279921756bc26244aa059634f39167bd45 Mon Sep 17 00:00:00 2001
From: tmdeveloper007 <tmdeveloper007@users.noreply.github.com>
Date: Tue, 23 Jun 2026 07:47:08 +0000
Subject: [PATCH] test : added unit tests for FilterPreset and SavedViewCreate
 Pydantic validators

---
 testing/backend/unit/test_saved_views.py | 82 +++++++++++++++++++++++-
 1 file changed, 81 insertions(+), 1 deletion(-)

diff --git a/testing/backend/unit/test_saved_views.py b/testing/backend/unit/test_saved_views.py
index f8780a7ab..b196e46b2 100644
--- a/testing/backend/unit/test_saved_views.py
+++ b/testing/backend/unit/test_saved_views.py
@@ -361,4 +361,84 @@ async def test_migration_failure_raises_runtime_error(tmp_path):
     finally:
         if db and db._connection:
             await db.disconnect()
-        broken.unlink(missing_ok=True)
\ No newline at end of file
+        broken.unlink(missing_ok=True)
+
+
+# ─── FilterPreset model validators ─────────────────────────────────────────────
+
+from backend.secuscan.saved_views import FilterPreset, SavedViewCreate
+from pydantic import ValidationError
+
+
+class TestFilterPresetDefaults:
+    def test_default_severity_is_all(self):
+        preset = FilterPreset()
+        assert preset.severity == "all"
+
+    def test_default_sort_mode_is_severity(self):
+        preset = FilterPreset()
+        assert preset.sortMode == "severity"
+
+    def test_default_scanner_is_all(self):
+        preset = FilterPreset()
+        assert preset.scanner == "all"
+
+
+class TestFilterPresetValidateSortMode:
+    def test_valid_sort_modes(self):
+        for mode in ("severity", "newest", "oldest", "target"):
+            preset = FilterPreset(sortMode=mode)
+            assert preset.sortMode == mode
+
+    def test_invalid_sort_mode_raises(self):
+        with pytest.raises(ValidationError) as exc_info:
+            FilterPreset(sortMode="invalid_mode")
+        assert "sortMode must be one of" in str(exc_info.value)
+
+
+class TestFilterPresetValidateSeverity:
+    def test_valid_severities(self):
+        for sev in ("all", "critical", "high", "medium", "low", "info"):
+            preset = FilterPreset(severity=sev)
+            assert preset.severity == sev
+
+    def test_invalid_severity_raises(self):
+        with pytest.raises(ValidationError) as exc_info:
+            FilterPreset(severity="dangerous")
+        assert "severity must be one of" in str(exc_info.value)
+
+
+# ─── SavedViewCreate model validators ──────────────────────────────────────────
+
+class TestSavedViewCreateStripName:
+    def test_valid_name_passes(self):
+        sv = SavedViewCreate(name="My View", filter_json='{"severity":"all"}')
+        assert sv.name == "My View"
+
+    def test_strips_leading_trailing_whitespace(self):
+        sv = SavedViewCreate(name="  trimmed  ", filter_json='{"severity":"all"}')
+        assert sv.name == "trimmed"
+
+    def test_blank_name_raises(self):
+        with pytest.raises(ValidationError) as exc_info:
+            SavedViewCreate(name="   ", filter_json='{"severity":"all"}')
+        assert "name cannot be blank" in str(exc_info.value)
+
+    def test_empty_string_name_raises(self):
+        with pytest.raises(ValidationError) as exc_info:
+            SavedViewCreate(name="", filter_json='{"severity":"all"}')
+        # Pydantic's min_length=1 constraint fires before field_validator,
+        # raising string_too_short.
+        assert "string_too_short" in str(exc_info.value)
+
+
+class TestSavedViewCreateValidateFilterJson:
+    def test_valid_json_passes(self):
+        sv = SavedViewCreate(name="v", filter_json='{"severity":"critical"}')
+        assert sv.filter_json == '{"severity":"critical"}'
+
+    def test_malformed_json_raises(self):
+        with pytest.raises(ValidationError) as exc_info:
+            SavedViewCreate(name="v", filter_json="not json")
+        # pydantic raises an error for invalid JSON in field_validator
+        assert "validation error" in str(exc_info.value).lower()