Dark Mode is Per-book Regardless of Global Dark Mode Setting

[getthething]

Device

X4 Pro

Affected Version

1.5.1 RC4

EPUB Optimization

No / Not Applicable

Cache State

Yes, reading cache (Settings > System > Clear Reading Cache)

Describe the Bug

Not sure if this intentional or a bug. But I opened a new book and the X4 pro was still in dark mode. So I disabled it, then opened a book I was previously reading and it opened in dark mode, disabled it, then opened the first book again to see and it was now in light mode. So I opened a 3rd book and it was in dark mode still. I noticed dark mode was set to “on” in reader settings but when set to “off” the book that was previously already in dark mode, stayed in dark mode. It doesn't seem to make a difference if the global dark mode setting is set to on or off.

I cleared the reading cache as well as deleted all the .epub_ folders in the .crosspoint folder and the issue remains.

Steps to Reproduce

Enable dark mode in a book
Switch to different book
See if dark mode is on. If on, disable it, switch to first book.
Dark mode is on for the first book.

Expected Behavior

Dark mode should be system wide. Disable it and it is off until disabled again for all books.

File Provided

Not Applicable

Relevant Log Output/Screenshots

[uxjulia]

Dark mode in the system settings apply to all newly opened books. Dark mode in the book settings apply to that book and overrides the global settings.

[getthething]

Dark mode in the system settings apply to all newly opened books. Dark mode in the book settings apply to that book and overrides the global settings.

Just to clarify, by system settings, you mean the dark mode option in the "reader" submenu of settings? I don't see a way to enable dark mode while in a book other than with a quick action. Which is what I have set up. I assumed the quick action toggle switched the global setting.

I typically only use dark mode at night, not on a book basis. Would it be within you scope to consider either scheduling dark mode, or make the quick action dark mode option disable/enable it globally?

[uxjulia]

You don't see an option in the reader's Book Options > Dark Mode?

In any case, a system-wide dark mode will be added for x4-pro and sticky devices soon so this is all going to be changed.

[getthething]

You don't see an option in the reader's Book Options > Dark Mode?

In any case, a system-wide dark mode will be added for x4-pro and sticky devices soon so this is all going to be changed.

Oh I'm a ding dong. I overlooked "book options". I apologize. That doesn't address my concern ultimately though. I'd like dark mode to be on for everything or off for everything and the quick actions dark mode shortcut seems to only toggle it at the book level. I'm big on using the shortcuts when possible so I don't have to navigate into nested menus. Typically I'll be reading during the day in light mode and then when I read in bed I'll switch to dark mode. I'd rather not have to toggle it for each book. TBH, I miss having it in the light menu. I assumed that's how most people would use it, but perhaps I'm in the minority.

[uxjulia]

Crossink never had it in the light menu haha you must be thinking of Crosspoint. But yeah, dark mode is one of those options that can be set per book and so it'd override the global setting. If you toggled dark mode in book, it should've toggled it correctly for that book. But a new book would inherit your global settings.

System-wide dark mode (for touch devices) is getting introduced soon though (it's already implemented on my local development branch) which will remove the per-book setting. And by system-wide, I mean EVERYTHING becomes dark. Not just the reader.

[getthething]

Crossink never had it in the light menu haha you must be thinking of Crosspoint. But yeah, dark mode is one of those options that can be set per book and so it'd override the global setting. If you toggled dark mode in book, it should've toggled it correctly for that book. But a new book would inherit your global settings.

System-wide dark mode is getting introduced soon though (it's already implemented on my local development branch) which will remove the per-book setting.

Oh yep. It was Crosspoint.

Sounds good I'll just wait for that. Thanks!

[natruok]

System-wide dark mode (for touch devices) is getting introduced soon though (it's already implemented on my local development branch) which will remove the per-book setting. And by system-wide, I mean EVERYTHING becomes dark. Not just the reader.

Hi sorry to jump in here — does this imply that system-wide dark mode already exists for non-touch devices? I'm using X3, and I've been trying to find this option but can't seem to locate anything outside of reader settings for dark mode

[uxjulia]

System-wide dark mode (for touch devices) is getting introduced soon though (it's already implemented on my local development branch) which will remove the per-book setting. And by system-wide, I mean EVERYTHING becomes dark. Not just the reader.

Hi sorry to jump in here — does this imply that system-wide dark mode already exists for non-touch devices? I'm using X3, and I've been trying to find this option but can't seem to locate anything outside of reader settings for dark mode

It doesn't already exist for any Crossink device. It will be implemented only for touch devices soon (the current panels on the non-touch devices ghost really badly from my tests, which was on an OG X4). Honestly with all the panel variations nowadays it's really hard to verify from one device to another how things will work out. With the history of people opening ghosting-related issues, if I were to expand system-wide dark mode to X3/X4 devices, I think I would be inundated with tickets. I'll need broader testing to be comfortable with releasing this for those devices.

[uxjulia]

System-wide dark mode (for touch devices) is getting introduced soon though (it's already implemented on my local development branch) which will remove the per-book setting. And by system-wide, I mean EVERYTHING becomes dark. Not just the reader.

Hi sorry to jump in here — does this imply that system-wide dark mode already exists for non-touch devices? I'm using X3, and I've been trying to find this option but can't seem to locate anything outside of reader settings for dark mode

It doesn't already exist for any Crossink device. It will be implemented only for touch devices soon (the current panels on the non-touch devices ghost really badly from my tests, which was on an OG X4). Honestly with all the panel variations nowadays it's really hard to verify from one device to another how things will work out. With the history of people opening ghosting-related issues, if I were to expand system-wide dark mode to X3/X4 devices, I think I would be inundated with tickets. I'll need broader testing to be comfortable with releasing this for those devices.

Welp, it accidentally went in for non-touch devices too so now it'll be available for everyone! If I hear enough ghosting complaints though, I may yank it.