From 11a962d9e70ad067a129ce8a79cf8b5640420e4c Mon Sep 17 00:00:00 2001 From: "totally-not-ai[bot]" <290682512+totally-not-ai[bot]@users.noreply.github.com> Date: Tue, 22 Sep 2026 06:00:50 +0000 Subject: [PATCH 1/2] ci: point the @since reconciliation at the real module source roots The reconcile-since-tags action defaults each entry's source root to /src/main/java, but our module directories are named after the module (shared, junit6, spring, quarkus) rather than after the published artifact. Every source root was therefore missing, the action skipped all four modules, and the workflow finished in under a minute without producing any change to open a PR from. Spell out the source roots with the action's "=" syntax. A local run of the action now reconciles 39 files. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/update-since-tags.yml | 10 ++++++---- .gitignore | 1 + 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/update-since-tags.yml b/.github/workflows/update-since-tags.yml index 87910af9..1373d87f 100644 --- a/.github/workflows/update-since-tags.yml +++ b/.github/workflows/update-since-tags.yml @@ -40,11 +40,13 @@ jobs: with: group-id: com.vaadin version: ${{ inputs.dev }} + # Source roots are spelled out because the module directories are + # named after the module, not after the published artifact. artifacts: | - browserless-test-shared - browserless-test-junit6 - browserless-test-spring - browserless-test-quarkus + browserless-test-shared=shared/src/main/java + browserless-test-junit6=junit6/src/main/java + browserless-test-spring=spring/src/main/java + browserless-test-quarkus=quarkus/src/main/java - name: Open pull request uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6.1.0 diff --git a/.gitignore b/.gitignore index e6a82ae2..0be38590 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ target spotless-index +.since-index From f9fb3746e641b7d171fc1369904ed8ab206cdedc Mon Sep 17 00:00:00 2001 From: "totally-not-ai[bot]" <290682512+totally-not-ai[bot]@users.noreply.github.com> Date: Tue, 22 Sep 2026 06:07:02 +0000 Subject: [PATCH 2/2] ci: bump reconcile-since-tags to the version that rejects missing source roots Picks up vaadin/github-actions#7, which aborts the run when a configured source root does not exist instead of skipping it silently, so a repeat of the misconfiguration this branch fixes fails the workflow instead of finishing green with an empty diff. Also includes vaadin/github-actions#6, which refuses to build an index with a failed release download. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/update-since-tags.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-since-tags.yml b/.github/workflows/update-since-tags.yml index 1373d87f..b4f30c12 100644 --- a/.github/workflows/update-since-tags.yml +++ b/.github/workflows/update-since-tags.yml @@ -36,7 +36,7 @@ jobs: cache: maven - id: since - uses: vaadin/github-actions/reconcile-since-tags@8743430abc47b783add936899c41a10f1d6d9987 + uses: vaadin/github-actions/reconcile-since-tags@452570a6575db482f7a602673b26fbe891422f65 with: group-id: com.vaadin version: ${{ inputs.dev }}