From 3f2c71fb88a1f5e04075f4a9b49c2ed262fee63b Mon Sep 17 00:00:00 2001 From: "totally-not-ai[bot]" <290682512+totally-not-ai[bot]@users.noreply.github.com> Date: Tue, 22 Sep 2026 13:12:41 +0300 Subject: [PATCH] ci: point the @since reconciliation at the real module source roots (#258) ## Summary The `@since` tag workflow never updated anything, because it looked for source files in folders that do not exist. This change tells it where each module's sources really live, so the workflow can do its job again. ## What changed This is a CI-only change. No production code, no API change, nothing for users of the library to adapt. - The `reconcile-since-tags` action assumes each artifact's sources are in `/src/main/java`. Our directories are named after the module (`shared`, `junit6`, `spring`, `quarkus`), not after the published artifact, so every source root was missing and all four modules were skipped. The workflow then finished in under a minute with no changes and no pull request. - The `artifacts` list in `.github/workflows/update-since-tags.yml` now spells out each source root with the action's `=` syntax. A local run reconciles 39 files. - Added `.since-index` to `.gitignore` so the local index the action writes is not committed by accident. Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) --- .github/workflows/update-since-tags.yml | 12 +++++++----- .gitignore | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/update-since-tags.yml b/.github/workflows/update-since-tags.yml index 87910af9..b4f30c12 100644 --- a/.github/workflows/update-since-tags.yml +++ b/.github/workflows/update-since-tags.yml @@ -36,15 +36,17 @@ jobs: cache: maven - id: since - uses: vaadin/github-actions/reconcile-since-tags@8743430abc47b783add936899c41a10f1d6d9987 + uses: vaadin/github-actions/reconcile-since-tags@452570a6575db482f7a602673b26fbe891422f65 with: group-id: com.vaadin version: ${{ inputs.dev }} + # Source roots are spelled out because the module directories are + # named after the module, not after the published artifact. artifacts: | - browserless-test-shared - browserless-test-junit6 - browserless-test-spring - browserless-test-quarkus + browserless-test-shared=shared/src/main/java + browserless-test-junit6=junit6/src/main/java + browserless-test-spring=spring/src/main/java + browserless-test-quarkus=quarkus/src/main/java - name: Open pull request uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6.1.0 diff --git a/.gitignore b/.gitignore index e6a82ae2..0be38590 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ target spotless-index +.since-index