From 02a53bbdc6f05196ce6190ae08672054f4e96c84 Mon Sep 17 00:00:00 2001 From: haosenwang1018 <167664334+haosenwang1018@users.noreply.github.com> Date: Thu, 26 Feb 2026 02:16:46 +0000 Subject: [PATCH] fix: replace 106 bare except clauses with except Exception --- misc/experiments/testvtk.py | 2 +- packages/vaex-astro/vaex/astro/export.py | 6 ++-- packages/vaex-astro/vaex/astro/fits.py | 4 +-- packages/vaex-astro/vaex/astro/tap.py | 2 +- packages/vaex-core/vaex/__init__.py | 8 ++--- packages/vaex-core/vaex/array_types.py | 2 +- packages/vaex-core/vaex/convert.py | 2 +- packages/vaex-core/vaex/dataframe.py | 30 +++++++++---------- packages/vaex-core/vaex/dataframe_protocol.py | 4 +-- packages/vaex-core/vaex/dataset_misc.py | 4 +-- packages/vaex-core/vaex/export.py | 2 +- packages/vaex-core/vaex/expression.py | 4 +-- packages/vaex-core/vaex/ext/bokeh.py | 2 +- packages/vaex-core/vaex/ext/common.py | 2 +- packages/vaex-core/vaex/ext/ipyvolume.py | 2 +- packages/vaex-core/vaex/file/column.py | 2 +- packages/vaex-core/vaex/kld.py | 2 +- packages/vaex-core/vaex/legacy.py | 2 +- packages/vaex-core/vaex/misc/expressions.py | 2 +- packages/vaex-core/vaex/misc/parallelize.py | 2 +- packages/vaex-core/vaex/misc/samp.py | 4 +-- packages/vaex-core/vaex/multithreading.py | 2 +- packages/vaex-core/vaex/parallelize.py | 2 +- packages/vaex-core/vaex/promise.py | 2 +- packages/vaex-core/vaex/samp.py | 6 ++-- packages/vaex-core/vaex/scopes.py | 2 +- packages/vaex-core/vaex/settings.py | 4 +-- packages/vaex-core/vaex/test/plot.py | 2 +- packages/vaex-core/vaex/utils.py | 4 +-- packages/vaex-hdf5/vaex/hdf5/dataset.py | 12 ++++---- packages/vaex-hdf5/vaex/hdf5/export.py | 6 ++-- .../vaex-jupyter/vaex/jupyter/ipyvolume.py | 6 ++-- .../vaex/jupyter/vendor/contextlib.py | 6 ++-- packages/vaex-server/vaex/server/fastapi.py | 4 +-- .../vaex-server/vaex/server/tornado_server.py | 2 +- packages/vaex-ui/vaex/ui/expressions.py | 2 +- packages/vaex-ui/vaex/ui/main.py | 16 +++++----- packages/vaex-ui/vaex/ui/plot_windows.py | 8 ++--- .../vaex-ui/vaex/ui/plugin/dispersions.py | 2 +- packages/vaex-ui/vaex/ui/qt.py | 6 ++-- packages/vaex-ui/vaex/ui/ranking.py | 2 +- packages/vaex-ui/vaex/ui/storage.py | 2 +- packages/vaex-ui/vaex/ui/table.py | 2 +- packages/vaex-ui/vaex/ui/undo.py | 4 +-- py2app.py | 6 ++-- tests/common.py | 6 ++-- tests/jit_test.py | 2 +- tests/jupyter/async_test.py | 2 +- 48 files changed, 105 insertions(+), 105 deletions(-) diff --git a/misc/experiments/testvtk.py b/misc/experiments/testvtk.py index f3bfb9cd71..32f09aa1f3 100644 --- a/misc/experiments/testvtk.py +++ b/misc/experiments/testvtk.py @@ -3,7 +3,7 @@ import vtk try: from PyQt4 import QtCore, QtGui -except: +except Exception: from PySide import QtCore, QtGui from vtk.qt4.QVTKRenderWindowInteractor import QVTKRenderWindowInteractor import vtk.util.numpy_support diff --git a/packages/vaex-astro/vaex/astro/export.py b/packages/vaex-astro/vaex/astro/export.py index f14caaf0e8..29a7130039 100644 --- a/packages/vaex-astro/vaex/astro/export.py +++ b/packages/vaex-astro/vaex/astro/export.py @@ -13,7 +13,7 @@ on_rtd = os.environ.get('READTHEDOCS', None) == 'True' try: import h5py -except: +except Exception: if not on_rtd: raise @@ -65,7 +65,7 @@ def export_hdf5_v1(dataset, path, column_names=None, byteorder="=", shuffle=Fals else: try: array = h5file_output.require_dataset("/data/%s" % column_name, shape=shape, dtype=dtype.newbyteorder(byteorder)) - except: + except Exception: logging.exception("error creating dataset for %r, with type %r " % (column_name, dtype)) array[0] = array[0] # make sure the array really exists random_index_name = None @@ -155,7 +155,7 @@ def export_hdf5(dataset, path, column_names=None, byteorder="=", shuffle=False, else: try: array = h5column_output.require_dataset('data', shape=shape, dtype=dtype.newbyteorder(byteorder)) - except: + except Exception: logging.exception("error creating dataset for %r, with type %r " % (column_name, dtype)) array[0] = array[0] # make sure the array really exists diff --git a/packages/vaex-astro/vaex/astro/fits.py b/packages/vaex-astro/vaex/astro/fits.py index ba09e1b30c..0f50c485a8 100644 --- a/packages/vaex-astro/vaex/astro/fits.py +++ b/packages/vaex-astro/vaex/astro/fits.py @@ -106,7 +106,7 @@ def _check_null(self, table, column_name, column, i): def _try_votable(self, table): try: from io import BytesIO as StringIO - except: + except Exception: from StringIO import StringIO if table.data is None: return @@ -140,7 +140,7 @@ def _get_column_meta_data(self, table, column_name, column, i): unit = _try_unit(column.unit) if unit: self.units[column_name] = unit - except: + except Exception: logger.exception("could not understand unit: %s" % column.unit) else: # we may want to try ourselves unit_header_name = "TUNIT%d" % (i+1) diff --git a/packages/vaex-astro/vaex/astro/tap.py b/packages/vaex-astro/vaex/astro/tap.py index cca41f678d..e4556b5c16 100644 --- a/packages/vaex-astro/vaex/astro/tap.py +++ b/packages/vaex-astro/vaex/astro/tap.py @@ -164,7 +164,7 @@ def can_open(cls, path, *args, **kwargs): url = None try: url = urlparse(path) - except: + except Exception: return False if url.scheme: if url.scheme.startswith("tap+http"): # will also catch https diff --git a/packages/vaex-core/vaex/__init__.py b/packages/vaex-core/vaex/__init__.py index 5724d9b938..299ac5eadf 100644 --- a/packages/vaex-core/vaex/__init__.py +++ b/packages/vaex-core/vaex/__init__.py @@ -73,7 +73,7 @@ try: from . import version -except: +except Exception: import sys print("version file not found, please run git/hooks/post-commit or git/hooks/post-checkout and/or install them as hooks (see git/README)", file=sys.stderr) raise @@ -265,7 +265,7 @@ def open(path, convert=False, progress=None, shuffle=False, fs_options={}, fs=No if df is None: raise IOError('Unknown error opening: {}'.format(path)) return df - except: + except Exception: logger.exception("error opening %r" % path) raise @@ -619,7 +619,7 @@ def _read_csv_read(filename_or_buffer, copy_index, chunk_size, fs_options={}, fs if "compression" not in kwargs: try: path = vaex.file.stringyfy(filename_or_buffer) - except: + except Exception: path = None if path: parts = path.rsplit('.', 3) @@ -703,7 +703,7 @@ def set_log_level_off(): with open(import_script) as f: code = compile(f.read(), import_script, 'exec') exec(code) - except: + except Exception: import traceback traceback.print_stack() diff --git a/packages/vaex-core/vaex/array_types.py b/packages/vaex-core/vaex/array_types.py index 3e10f3189c..2975209db3 100644 --- a/packages/vaex-core/vaex/array_types.py +++ b/packages/vaex-core/vaex/array_types.py @@ -218,7 +218,7 @@ def convert(x, type, default_type="numpy"): else: try: return pa.array(x).tolist() - except: + except Exception: return np.array(x).tolist() elif type is None: if isinstance(x, (list, tuple)): diff --git a/packages/vaex-core/vaex/convert.py b/packages/vaex-core/vaex/convert.py index bf0abc5aa5..d1e96816e8 100644 --- a/packages/vaex-core/vaex/convert.py +++ b/packages/vaex-core/vaex/convert.py @@ -166,7 +166,7 @@ def main(argv): if not args.quiet: print("\noutput to %s" % os.path.abspath(args.output)) df.close() - except: + except Exception: if not args.quiet: print("\nfailed to write to%s" % os.path.abspath(args.output)) if args.delete: diff --git a/packages/vaex-core/vaex/dataframe.py b/packages/vaex-core/vaex/dataframe.py index c62e6a4b6b..abc23aaa2b 100644 --- a/packages/vaex-core/vaex/dataframe.py +++ b/packages/vaex-core/vaex/dataframe.py @@ -2012,7 +2012,7 @@ def mode(self, expression, binby=[], limits=None, shape=256, mode_shape=64, mode try: len(shape) shape = tuple(shape) - except: + except Exception: shape = len(binby) * (shape,) shape = (mode_shape,) + shape subspace = self(*(list(binby) + [expression])) @@ -2282,7 +2282,7 @@ def data_type(self, expression, array_type=None, internal=False, axis=0): expression = vaex.utils.valid_expression(self.get_column_names(hidden=True), expression) try: data = self.evaluate(expression, 0, 1, filtered=False, array_type=array_type, parallel=False) - except: + except Exception: data = self.evaluate(expression, 0, 1, filtered=True, array_type=array_type, parallel=False) if data_type is None: # means we have to determine it from the data @@ -2366,7 +2366,7 @@ def label(self, expression, unit=None, output_unit=None, format="latex_inline"): if output_unit and unit: # avoid unnecessary error msg'es output_unit.to(unit) unit = output_unit - except: + except Exception: logger.exception("unit error") if unit is not None: label = "%s (%s)" % (label, unit.to_string('latex_inline')) @@ -2397,12 +2397,12 @@ def unit(self, expression, default=None): unit = unit_or_quantity.unit if hasattr(unit_or_quantity, "unit") else unit_or_quantity unit_types = (astropy.units.core.UnitBase, ) return unit if isinstance(unit, unit_types) else None - except: + except Exception: # logger.exception("error evaluating unit expression: %s", expression) # astropy doesn't add units, so we try with a quatiti try: return eval(expression, expression_namespace, scopes.UnitScope(self, 1.)).unit - except: + except Exception: # logger.exception("error evaluating unit expression: %s", expression) return default @@ -2473,7 +2473,7 @@ def selections_favorite_load(self): selections_dict = vaex.utils.read_json_or_yaml(path) for key, value in selections_dict.items(): self.favorite_selections[key] = selections.selection_from_dict(self, value) - except: + except Exception: logger.exception("non fatal error") def get_private_dir(self, create=False): @@ -2904,7 +2904,7 @@ def remove_virtual_meta(self): os.remove(path) if not os.listdir(dir): os.rmdir(dir) - except: + except Exception: logger.exception("error while trying to remove %s or %s", path, dir) # def remove_meta(self): # path = os.path.join(self.get_private_dir(create=True), "meta.yaml") @@ -2948,7 +2948,7 @@ def update_virtual_meta(self): self.descriptions.update(meta_info["descriptions"]) units = {key: astropy.units.Unit(value) for key, value in meta_info["units"].items()} self.units.update(units) - except: + except Exception: logger.exception("non fatal error") @_hidden @@ -2987,7 +2987,7 @@ def update_meta(self): # self.variables.update(meta_info["variables"]) units = {key: astropy.units.Unit(value) for key, value in meta_info["units"].items()} self.units.update(units) - except: + except Exception: logger.exception("non fatal error, but could read/understand %s", path) def is_local(self): @@ -3858,7 +3858,7 @@ def _rename(self, old, new, rename_meta_data=False): if isinstance(getattr(self, old), Expression): try: delattr(self, old) - except: + except Exception: pass self._save_assign_expression(new) existing_expressions = [k() for k in self._expressions] @@ -4105,12 +4105,12 @@ def table_part(k1, k2, parts): df = self[k1:k2] try: values = dict(zip(column_names, df.evaluate(column_names))) - except: + except Exception: values = {} for i, name in enumerate(column_names): try: values[name] = df.evaluate(name) - except: + except Exception: values[name] = ["error"] * (N) logger.exception('error evaluating: %s at rows %i-%i' % (name, k1, k2)) for i in range(k2 - k1): @@ -4184,7 +4184,7 @@ def table_part(k1, k2, parts): for name in column_names: try: data_parts[name] = self.evaluate(name, i1=k1, i2=k2) - except: + except Exception: data_parts[name] = ["error"] * (N) logger.exception('error evaluating: %s at rows %i-%i' % (name, k1, k2)) for i in range(k2 - k1): @@ -5490,7 +5490,7 @@ def _real_drop(self, item): try: if isinstance(getattr(self, name), Expression): delattr(self, name) - except: + except Exception: pass @docsubst @@ -6679,7 +6679,7 @@ def equal_mask(a, b): for i in range(min(len(values1), show)): try: diff = values1[i] - values2[i] - except: + except Exception: diff = "does not exists" print("%s[%d] == %s != %s other.%s[%d] (diff = %s)" % (column_name, indices[i], values1[i], values2[i], column_name, indices[i], diff)) return different_values, missing, type_mismatch, meta_mismatch diff --git a/packages/vaex-core/vaex/dataframe_protocol.py b/packages/vaex-core/vaex/dataframe_protocol.py index 48e91ae2db..0f8dbba796 100644 --- a/packages/vaex-core/vaex/dataframe_protocol.py +++ b/packages/vaex-core/vaex/dataframe_protocol.py @@ -585,12 +585,12 @@ def get_buffers(self) -> Dict[str, Any]: buffers["data"] = self._get_data_buffer() try: buffers["validity"] = self._get_validity_buffer() - except: + except Exception: buffers["validity"] = None try: buffers["offsets"] = self._get_offsets_buffer() - except: + except Exception: buffers["offsets"] = None return buffers diff --git a/packages/vaex-core/vaex/dataset_misc.py b/packages/vaex-core/vaex/dataset_misc.py index bbea381fdb..5c343a52dc 100644 --- a/packages/vaex-core/vaex/dataset_misc.py +++ b/packages/vaex-core/vaex/dataset_misc.py @@ -117,13 +117,13 @@ def _try_unit(unit): unit = astropy.units.Unit(str(unit)) if not isinstance(unit, astropy.units.UnrecognizedUnit): return unit - except: + except Exception: #logger.exception("could not parse unit: %r", unit) pass try: unit_mangle = re.match(r".*\[(.*)\]", str(unit)).groups()[0] unit = astropy.units.Unit(unit_mangle) - except: + except Exception: pass#logger.exception("could not parse unit: %r", unit) if isinstance(unit, six.string_types): return None diff --git a/packages/vaex-core/vaex/export.py b/packages/vaex-core/vaex/export.py index b2d6dfa764..f52f0e84a5 100644 --- a/packages/vaex-core/vaex/export.py +++ b/packages/vaex-core/vaex/export.py @@ -20,7 +20,7 @@ on_rtd = os.environ.get('READTHEDOCS', None) == 'True' try: import h5py -except: +except Exception: if not on_rtd: raise # from vaex.dataset import DatasetLocal diff --git a/packages/vaex-core/vaex/expression.py b/packages/vaex-core/vaex/expression.py index 1278630e7f..c1de0395c4 100644 --- a/packages/vaex-core/vaex/expression.py +++ b/packages/vaex-core/vaex/expression.py @@ -114,7 +114,7 @@ def f(a, b): a = self.index_values() try: stringy = isinstance(b, str) or b.is_string() - except: + except Exception: # this can happen when expression is a literal, like '1' (used in propagate_unc) # which causes the dtype to fail stringy = False @@ -1359,7 +1359,7 @@ def map(self, mapper, nan_value=None, missing_value=None, default_value=None, al def try_nan(x): try: return np.isnan(x) - except: + except Exception: return False mapper_nan_key_mask = np.array([try_nan(k) for k in mapper_keys]) mapper_has_nan = mapper_nan_key_mask.sum() > 0 diff --git a/packages/vaex-core/vaex/ext/bokeh.py b/packages/vaex-core/vaex/ext/bokeh.py index 46dff67529..184ed300b1 100644 --- a/packages/vaex-core/vaex/ext/bokeh.py +++ b/packages/vaex-core/vaex/ext/bokeh.py @@ -89,7 +89,7 @@ def update_in_main_thread(): rgba = create_image(job) if not job.cancelled: progress.description = "Done: %.1fs" % (time.time() - t0) - except: + except Exception: if not job.cancelled: progress.description = "error" raise diff --git a/packages/vaex-core/vaex/ext/common.py b/packages/vaex-core/vaex/ext/common.py index eb7e10b60e..8f070d4b89 100644 --- a/packages/vaex-core/vaex/ext/common.py +++ b/packages/vaex-core/vaex/ext/common.py @@ -29,7 +29,7 @@ def __call__(self): if not self.cancelled: try: self.result = self.f(self, **self.kwargs) - except: + except Exception: self.exception = True raise diff --git a/packages/vaex-core/vaex/ext/ipyvolume.py b/packages/vaex-core/vaex/ext/ipyvolume.py index 9f46a0b6bb..b1f1159ee8 100644 --- a/packages/vaex-core/vaex/ext/ipyvolume.py +++ b/packages/vaex-core/vaex/ext/ipyvolume.py @@ -42,7 +42,7 @@ def _update_image(self): if self.vcount_limits is not None: try: vcount_min, vcount_max = self.vcount_limits - except: + except Exception: vcount_min = self.vcount_limits if vcount_min is not None: ok &= (vcount > vcount_min) diff --git a/packages/vaex-core/vaex/file/column.py b/packages/vaex-core/vaex/file/column.py index afa10b81d7..f84305aa1c 100644 --- a/packages/vaex-core/vaex/file/column.py +++ b/packages/vaex-core/vaex/file/column.py @@ -2,7 +2,7 @@ fcntl = None try: import fcntl -except: +except Exception: pass import threading from ctypes import * diff --git a/packages/vaex-core/vaex/kld.py b/packages/vaex-core/vaex/kld.py index 5867acfac3..81ed82c6ea 100644 --- a/packages/vaex-core/vaex/kld.py +++ b/packages/vaex-core/vaex/kld.py @@ -70,7 +70,7 @@ def kld_shuffled(columns, Ngrid=128, datamins=None, datamaxes=None, offset=1): print((x, y, counts, counts_shuffled, datamins[0], datamaxes[0], datamins[1], datamaxes[1], offset)) try: vaex.histogram.hist2d_and_shuffled(x, y, counts, counts_shuffled, datamins[0], datamaxes[0], datamins[1], datamaxes[1], offset) - except: + except Exception: args = [x, y, counts, counts_shuffled, datamins[0], datamaxes[0], datamins[1], datamaxes[1], offset] sig = [numba.dispatcher.typeof_pyval(a) for a in args] print(sig) diff --git a/packages/vaex-core/vaex/legacy.py b/packages/vaex-core/vaex/legacy.py index 36fb1ec42d..59c2cbb016 100644 --- a/packages/vaex-core/vaex/legacy.py +++ b/packages/vaex-core/vaex/legacy.py @@ -35,7 +35,7 @@ def __init__(self, df, subspace, expressions, size, limits, masked=False, weight try: self.size[0] shape1 = tuple(self.size) - except: + except Exception: pass shape = (self.subspace.executor.thread_pool.nthreads,) + shape1 self.data = np.zeros(shape, dtype=self.dtype) diff --git a/packages/vaex-core/vaex/misc/expressions.py b/packages/vaex-core/vaex/misc/expressions.py index 7b2a4e6377..d89a1b0aeb 100644 --- a/packages/vaex-core/vaex/misc/expressions.py +++ b/packages/vaex-core/vaex/misc/expressions.py @@ -134,7 +134,7 @@ def __init__(self, var, args): self.args = args try: len(self.args) - except: + except Exception: self.args = (self.args,) def tovar(self): diff --git a/packages/vaex-core/vaex/misc/parallelize.py b/packages/vaex-core/vaex/misc/parallelize.py index 753d71e7ab..f63a1c630d 100644 --- a/packages/vaex-core/vaex/misc/parallelize.py +++ b/packages/vaex-core/vaex/misc/parallelize.py @@ -101,7 +101,7 @@ def __call__(self, *args, **kwargs): result = None try: result = self.function(*args, **kwargs) - except: + except Exception: info = "exception" exc_info = traceback.format_exc() return info, exc_info, result diff --git a/packages/vaex-core/vaex/misc/samp.py b/packages/vaex-core/vaex/misc/samp.py index 15d062d60b..bbcac3f817 100644 --- a/packages/vaex-core/vaex/misc/samp.py +++ b/packages/vaex-core/vaex/misc/samp.py @@ -64,7 +64,7 @@ def _onTableLoadVotable(self, private_key, sender_id, msg_id, mtype, params, ext name = params["name"] for callback in self.tableLoadCallbacks: callback(url, table_id, name) - except: + except Exception: logger.exception("event handler failed") if msg_id != None: # if SAMP call, send a reply @@ -78,6 +78,6 @@ def _onSampCall(self, private_key, sender_id, msg_id, mtype, params, extra): try: print(("Call:", repr(private_key), repr(sender_id), repr(msg_id), repr(mtype), repr(params), repr(extra))) self.client.ereply(msg_id, sampy.SAMP_STATUS_OK, result = {"txt": "printed"}) - except: + except Exception: print("errrrrrrororrrr hans!") diff --git a/packages/vaex-core/vaex/multithreading.py b/packages/vaex-core/vaex/multithreading.py index d4df43562d..001c2aba46 100644 --- a/packages/vaex-core/vaex/multithreading.py +++ b/packages/vaex-core/vaex/multithreading.py @@ -125,7 +125,7 @@ def cancellable_iter(): for value in iterator: try: pass - except: + except Exception: pass def _map(self, callable, iterator): diff --git a/packages/vaex-core/vaex/parallelize.py b/packages/vaex-core/vaex/parallelize.py index f019a427e3..fc3f7eb15b 100644 --- a/packages/vaex-core/vaex/parallelize.py +++ b/packages/vaex-core/vaex/parallelize.py @@ -108,7 +108,7 @@ def __call__(self, *args, **kwargs): result = None try: result = self.function(*args, **kwargs) - except: + except Exception: info = "exception" exc_info = traceback.format_exc() return info, exc_info, result diff --git a/packages/vaex-core/vaex/promise.py b/packages/vaex-core/vaex/promise.py index e2098154f9..8a29493265 100644 --- a/packages/vaex-core/vaex/promise.py +++ b/packages/vaex-core/vaex/promise.py @@ -141,7 +141,7 @@ def failure(reason): # print args try: Promise.unhandled(*args) - except: + except Exception: print("Error in unhandled handler") traceback.print_exc() return self.then(None, failure) diff --git a/packages/vaex-core/vaex/samp.py b/packages/vaex-core/vaex/samp.py index 253dc1c537..64456b9198 100644 --- a/packages/vaex-core/vaex/samp.py +++ b/packages/vaex-core/vaex/samp.py @@ -73,7 +73,7 @@ def _onTableLoadVotable(self, private_key, sender_id, msg_id, mtype, params, ext name = params["name"] for callback in self.tableLoadCallbacks: callback(url, table_id, name) - except: + except Exception: logger.exception("event handler failed") if msg_id is not None: # if SAMP call, send a reply @@ -87,7 +87,7 @@ def _onSampCall(self, private_key, sender_id, msg_id, mtype, params, extra): try: print(("Call:", repr(private_key), repr(sender_id), repr(msg_id), repr(mtype), repr(params), repr(extra))) self.client.ereply(msg_id, sampy.SAMP_STATUS_OK, result={"txt": "printed"}) - except: + except Exception: print("errrrrrrororrrr hans!") @@ -121,7 +121,7 @@ def wait_for_table(self): try: input = raw_input -except: +except Exception: pass # py2/3 comp try: diff --git a/packages/vaex-core/vaex/scopes.py b/packages/vaex-core/vaex/scopes.py index 94bfabe986..9f3f9b36f5 100644 --- a/packages/vaex-core/vaex/scopes.py +++ b/packages/vaex-core/vaex/scopes.py @@ -198,6 +198,6 @@ def __getitem__(self, variable): raise KeyError("Unknown variables or column: %r" % (variable,)) return self.values[variable] - except: + except Exception: # logger.exception("error in evaluating: %r" % variable) raise diff --git a/packages/vaex-core/vaex/settings.py b/packages/vaex-core/vaex/settings.py index 069388c660..469438edf1 100644 --- a/packages/vaex-core/vaex/settings.py +++ b/packages/vaex-core/vaex/settings.py @@ -15,7 +15,7 @@ try: import dotenv has_dotenv = True -except: +except Exception: has_dotenv = False @@ -36,7 +36,7 @@ class ConfigDefault: # try: # import ast # value = ast.literal_eval(value) -# except: +# except Exception: # pass # if isinstance(value, str): # import dask diff --git a/packages/vaex-core/vaex/test/plot.py b/packages/vaex-core/vaex/test/plot.py index 93232db551..6c07cb1a90 100644 --- a/packages/vaex-core/vaex/test/plot.py +++ b/packages/vaex-core/vaex/test/plot.py @@ -15,7 +15,7 @@ try: raw_input = input -except: +except Exception: pass # py2/3 fix base_path = os.path.dirname(__file__) diff --git a/packages/vaex-core/vaex/utils.py b/packages/vaex-core/vaex/utils.py index efaae61610..32fe751264 100644 --- a/packages/vaex-core/vaex/utils.py +++ b/packages/vaex-core/vaex/utils.py @@ -399,7 +399,7 @@ def listify(*args): try: _ = args[0][0] return True, args - except: + except Exception: return False, [[x] for x in args] @@ -950,7 +950,7 @@ def get_env_memory(key, default=None): if value is not None: try: value = ast.literal_eval(value) - except: + except Exception: pass if isinstance(value, str): value = dask.utils.parse_bytes(value) diff --git a/packages/vaex-hdf5/vaex/hdf5/dataset.py b/packages/vaex-hdf5/vaex/hdf5/dataset.py index 950429aff0..ff13382cbf 100644 --- a/packages/vaex-hdf5/vaex/hdf5/dataset.py +++ b/packages/vaex-hdf5/vaex/hdf5/dataset.py @@ -28,7 +28,7 @@ on_rtd = os.environ.get('READTHEDOCS', None) == 'True' try: import h5py -except: +except Exception: if not on_rtd: raise @@ -38,13 +38,13 @@ def _try_unit(unit): unit = astropy.units.Unit(str(unit)) if not isinstance(unit, astropy.units.UnrecognizedUnit): return unit - except: + except Exception: # logger.exception("could not parse unit: %r", unit) pass try: unit_mangle = re.match(".*\[(.*)\]", str(unit)).groups()[0] unit = astropy.units.Unit(unit_mangle) - except: + except Exception: pass # logger.exception("could not parse unit: %r", unit) if isinstance(unit, str): return None @@ -348,7 +348,7 @@ def check_format(self, *args, **kwargs): unitname = ensure_string(column.attrs["unit"]) if unitname and unitname != "None": self.units[column_name] = _try_unit(unitname) - except: + except Exception: logger.exception("error parsing unit: %s", column.attrs["unit"]) if "units" in column.attrs: # Amuse case unitname = ensure_string(column.attrs["units"]) @@ -447,7 +447,7 @@ def can_open(cls, path, *args, **kwargs): h5file = None try: h5file = h5py.File(path, "r") - except: + except Exception: return False if h5file is not None: with h5file: @@ -571,7 +571,7 @@ def can_open(cls, path, fs_options={}, fs=None, *args, **kwargs): h5file = None try: h5file = h5py.File(path, "r") - except: + except Exception: return False has_particles = False # for i in range(1,6): diff --git a/packages/vaex-hdf5/vaex/hdf5/export.py b/packages/vaex-hdf5/vaex/hdf5/export.py index 461cc0ec50..c51f7d61a5 100644 --- a/packages/vaex-hdf5/vaex/hdf5/export.py +++ b/packages/vaex-hdf5/vaex/hdf5/export.py @@ -17,7 +17,7 @@ on_rtd = os.environ.get('READTHEDOCS', None) == 'True' try: import h5py -except: +except Exception: if not on_rtd: raise @@ -69,7 +69,7 @@ def export_hdf5_v1(dataset, path, column_names=None, byteorder="=", shuffle=Fals else: try: array = h5file_output.require_dataset("/data/%s" % column_name, shape=shape, dtype=dtype.newbyteorder(byteorder)) - except: + except Exception: logging.exception("error creating dataset for %r, with type %r " % (column_name, dtype)) array[0] = array[0] # make sure the array really exists random_index_name = None @@ -195,7 +195,7 @@ def export_hdf5(dataset, path, column_names=None, byteorder="=", shuffle=False, else: try: array = h5column_output.require_dataset('data', shape=shape, dtype=dtype.numpy.newbyteorder(byteorder)) - except: + except Exception: logging.exception("error creating dataset for %r, with type %r " % (column_name, dtype)) del h5columns_output[column_name] column_names.remove(column_name) diff --git a/packages/vaex-jupyter/vaex/jupyter/ipyvolume.py b/packages/vaex-jupyter/vaex/jupyter/ipyvolume.py index ed595906ca..b26810da14 100644 --- a/packages/vaex-jupyter/vaex/jupyter/ipyvolume.py +++ b/packages/vaex-jupyter/vaex/jupyter/ipyvolume.py @@ -15,11 +15,11 @@ def xyz(shape=128, limits=[-3, 3], spherical=False, sparse=True, centers=False): dim = 3 try: shape[0] - except: + except Exception: shape = [shape] * dim try: limits[0][0] - except: + except Exception: limits = [limits] * dim if centers: v = [slice(vmin + (vmax - vmin) / float(N) / 2, vmax - (vmax - vmin) / float(N) / 4, (vmax - vmin) / float(N)) for (vmin, vmax), N in zip(limits, shape)] @@ -106,7 +106,7 @@ def update_vectors(self, vcount, vgrids, vcount_limits): if vcount_limits is not None: try: vcount_min, vcount_max = vcount_limits - except: + except Exception: vcount_min = self.vcount_limits if vcount_min is not None: ok &= (vcount > vcount_min) diff --git a/packages/vaex-jupyter/vaex/jupyter/vendor/contextlib.py b/packages/vaex-jupyter/vaex/jupyter/vendor/contextlib.py index 16282a7e59..c538570f61 100644 --- a/packages/vaex-jupyter/vaex/jupyter/vendor/contextlib.py +++ b/packages/vaex-jupyter/vaex/jupyter/vendor/contextlib.py @@ -197,7 +197,7 @@ def __exit__(self, type, value, traceback): if type is StopIteration and exc.__cause__ is value: return False raise - except: + except Exception: # only re-raise if it's *not* the exception that was # passed to throw(), because __exit__() must not raise # an exception unless __exit__() itself failed. But throw() @@ -564,7 +564,7 @@ def _fix_exception_context(new_exc, old_exc): suppressed_exc = True pending_raise = False exc_details = (None, None, None) - except: + except Exception: new_exc_details = sys.exc_info() # simulate the stack of exceptions by setting the context _fix_exception_context(new_exc_details[1], exc_details[1]) @@ -718,7 +718,7 @@ def _fix_exception_context(new_exc, old_exc): suppressed_exc = True pending_raise = False exc_details = (None, None, None) - except: + except Exception: new_exc_details = sys.exc_info() # simulate the stack of exceptions by setting the context _fix_exception_context(new_exc_details[1], exc_details[1]) diff --git a/packages/vaex-server/vaex/server/fastapi.py b/packages/vaex-server/vaex/server/fastapi.py index ac4bf5b3f6..f6f8183416 100644 --- a/packages/vaex-server/vaex/server/fastapi.py +++ b/packages/vaex-server/vaex/server/fastapi.py @@ -144,7 +144,7 @@ def _number(v): return v try: return float(v) - except: + except Exception: return v async def _compute_histogram(input: HistogramInput) -> HistogramOutput: @@ -366,7 +366,7 @@ def mainloop(self): self.started.set() try: self.server.run() - except: + except Exception: logger.exception("Oops, server stopped unexpectedly") finally: self.stopped.set() diff --git a/packages/vaex-server/vaex/server/tornado_server.py b/packages/vaex-server/vaex/server/tornado_server.py index 01bcc4b7c1..22beaaacfd 100644 --- a/packages/vaex-server/vaex/server/tornado_server.py +++ b/packages/vaex-server/vaex/server/tornado_server.py @@ -51,7 +51,7 @@ async def on_message(self, websocket_msg): logger.debug("get msg: %r", websocket_msg) try: asyncio.create_task(self._on_message(websocket_msg)) - except: + except Exception: logger.exception("creating task") async def _on_message(self, websocket_msg): diff --git a/packages/vaex-ui/vaex/ui/expressions.py b/packages/vaex-ui/vaex/ui/expressions.py index 2a30b5ecea..4c2820f34c 100644 --- a/packages/vaex-ui/vaex/ui/expressions.py +++ b/packages/vaex-ui/vaex/ui/expressions.py @@ -153,7 +153,7 @@ def __init__(self, var, args): self.args = args try: len(self.args) - except: + except Exception: self.args = (self.args,) def tovar(self): diff --git a/packages/vaex-ui/vaex/ui/main.py b/packages/vaex-ui/vaex/ui/main.py index 83716cf023..79e76349a2 100644 --- a/packages/vaex-ui/vaex/ui/main.py +++ b/packages/vaex-ui/vaex/ui/main.py @@ -41,7 +41,7 @@ import sip sip.setapi('QVariant', 2) sip.setapi('QString', 2) -except: +except Exception: pass darwin = "darwin" in platform.system().lower() frozen = getattr(sys, 'frozen', False) @@ -877,7 +877,7 @@ def drawbar(index, count, fraction, color=QtCore.Qt.red): self.tool_text = "\n".join(self.tool_lines) painter.end() self.setToolTip(self.tool_text) - except: + except Exception: pass @@ -1450,11 +1450,11 @@ def on_samp_ping_timer(self): if self.samp: try: self.samp.client.ping() - except: + except Exception: print("oops, ping went wrong, disconnect detected") try: self.samp.disconnect() - except: + except Exception: pass self.samp = None self.action_samp_connect.setChecked(self.samp is not None) @@ -1694,7 +1694,7 @@ def onSampConnect(self, ignore_error=False): self.samp.client.disconnect() self.samp = None # self.action_samp_connect.setText("disconnect from SAMP HUB" if self.samp else "conncet to SAMP HUB") - # except: + # except Exception: # dialog_exception(self, "Connecting to SAMP server", "Could not connect, make sure a SAMP HUB is running (for instance TOPCAT)") def _on_samp_notification(self, private_key, sender_id, mtype, params, extra): @@ -1869,7 +1869,7 @@ def _samp_find_datasets(self, id): for dataset in self.dataset_selector.datasets: if dataset.matches_url(id) or (dataset.samp_id == id): yield dataset - except: + except Exception: logger.exception("problem") def onSampSend(self): @@ -1903,7 +1903,7 @@ def onLoadTable(self, url, table_id, name): print("loading table", url, table_id, name) try: self.load(url, table_id, name) - except: + except Exception: logger.exception("load table") return @@ -1947,7 +1947,7 @@ def clean_up(self): print("disconnect samp") try: self.samp.client.disconnect() - except: + except Exception: logger.exception("error disconnecting from SAMP hub") # event.accept() return diff --git a/packages/vaex-ui/vaex/ui/plot_windows.py b/packages/vaex-ui/vaex/ui/plot_windows.py index e60e447cee..9b9e07ecb5 100644 --- a/packages/vaex-ui/vaex/ui/plot_windows.py +++ b/packages/vaex-ui/vaex/ui/plot_windows.py @@ -403,7 +403,7 @@ def get_default_label(self, axis=0): if first_layer.state.output_units[axis] and unit: # avoid unnecessary error msg'es output_unit.to(unit) unit = output_unit - except: + except Exception: logger.exception("unit error") logger.debug("unit: %r", unit) if unit is not None: @@ -2698,7 +2698,7 @@ def __call__(self, x, pos=None): axis = self.axes.xaxis if dim == 0 else self.axes.yaxis axis.set_major_locator(ScaledLocator(dx=scale)) axis.set_major_formatter(ScaledFormatter(dx=scale)) - except: + except Exception: pass titles = [layer.state.title for layer in self.layers if layer.state.title] @@ -2940,7 +2940,7 @@ def calculate_visuals(self, info, *blocks): if weights_block is not None: args = data_blocks, weights_block, self.counts, ranges vaex.histogram.hist2d_weights(blockx, blocky, self.counts_weights, weights_block, *ranges) - except: + except Exception: raise if mask is not None: @@ -3738,5 +3738,5 @@ def call(_=None, counter=None, callable=None): import vaex.ui.layers try: from vaex.ui.main import VaexApp -except: +except Exception: pass diff --git a/packages/vaex-ui/vaex/ui/plugin/dispersions.py b/packages/vaex-ui/vaex/ui/plugin/dispersions.py index 380d4b8227..ecaf016ffb 100644 --- a/packages/vaex-ui/vaex/ui/plugin/dispersions.py +++ b/packages/vaex-ui/vaex/ui/plugin/dispersions.py @@ -168,7 +168,7 @@ def draw_grids(self, axes, grid_map, grid_map_vector): try: covmatrix = [[sigmax**2, covxy], [covxy, sigmay**2]] eigen_values, eigen_vectors = np.linalg.eig(covmatrix) - except: + except Exception: pass else: scaling = 1./vmax * max_size diff --git a/packages/vaex-ui/vaex/ui/qt.py b/packages/vaex-ui/vaex/ui/qt.py index a2803afb7e..13936e54cb 100644 --- a/packages/vaex-ui/vaex/ui/qt.py +++ b/packages/vaex-ui/vaex/ui/qt.py @@ -480,14 +480,14 @@ def get(): if self.combobox_min.lineEdit().text().strip(): try: self.vmin = float(self.combobox_min.lineEdit().text()) - except: + except Exception: logger.exception("parsing vmin") dialog_error(self.combobox_min, "Error parsing number", "Cannot parse number: %s" % self.combobox_min.lineEdit().text()) if self.combobox_max.lineEdit().text().strip(): try: self.vmax = float(self.combobox_max.lineEdit().text()) - except: + except Exception: logger.exception("parsing vmax") dialog_error(self.combobox_max, "Error parsing number", "Cannot parse number: %s" % self.combobox_max.lineEdit().text()) return (self.vmin, self.vmax) if self.vmin is not None and self.vmax is not None else None @@ -985,7 +985,7 @@ def qt_exception(parent, exctype, value, traceback): if isinstance(f, collections.Callable): try: info += "%s: %r\n" % (attr, f()) - except: + except Exception: pass # , platform.architecture(), platform.dist(), platform.linux_distribution(), diff --git a/packages/vaex-ui/vaex/ui/ranking.py b/packages/vaex-ui/vaex/ui/ranking.py index 6c2d667b53..822a033b64 100644 --- a/packages/vaex-ui/vaex/ui/ranking.py +++ b/packages/vaex-ui/vaex/ui/ranking.py @@ -853,7 +853,7 @@ def onCalculateMinMax(self): ranges = minmax.get() self.table1d.setRanges(pairs, ranges) self.fill_range_map() - except: + except Exception: logger.exception("Error in min/max or cancelled") # dialog.hide() diff --git a/packages/vaex-ui/vaex/ui/storage.py b/packages/vaex-ui/vaex/ui/storage.py index 83f339dfd0..d55365455b 100644 --- a/packages/vaex-ui/vaex/ui/storage.py +++ b/packages/vaex-ui/vaex/ui/storage.py @@ -22,7 +22,7 @@ def load(self): if os.path.exists(self.path): try: self.all_options = json.load(open(self.path)) - except: + except Exception: logger.exception("error parsing settings from:" + self.path) def get_all(self, type_name, dataset): diff --git a/packages/vaex-ui/vaex/ui/table.py b/packages/vaex-ui/vaex/ui/table.py index 0f7e6e557b..79cc5d6d55 100644 --- a/packages/vaex-ui/vaex/ui/table.py +++ b/packages/vaex-ui/vaex/ui/table.py @@ -73,7 +73,7 @@ def data(self, index, role): return str(value) else: return "%s %s" % (value.dtype.name, value.shape) - except: + except Exception: pass # TODO: ok, it can be a scalar sometimes... should not happen, but can when an column expression is set to '0' return str(value) # column = [self.dataset.all_column_names[index.column()-1]] diff --git a/packages/vaex-ui/vaex/ui/undo.py b/packages/vaex-ui/vaex/ui/undo.py index 92d326dab7..b1c17f7012 100644 --- a/packages/vaex-ui/vaex/ui/undo.py +++ b/packages/vaex-ui/vaex/ui/undo.py @@ -18,7 +18,7 @@ def undo(self): self.actions_redo.insert(0, action) try: action.undo() - except: + except Exception: logger.exception("error executing action") logger.debug("history is %r-%r" % (self.actions_undo, self.actions_redo)) @@ -36,7 +36,7 @@ def redo(self): action = self.actions_redo.pop(0) try: action.do() - except: + except Exception: logger.exception("error executing action") self.actions_undo.append(action) logger.debug("history is %r-%r" % (self.actions_undo, self.actions_redo)) diff --git a/py2app.py b/py2app.py index c740d49b72..77555f8619 100644 --- a/py2app.py +++ b/py2app.py @@ -34,7 +34,7 @@ def system(cmd): try: import py2app.build_app has_py2app = True -except: +except Exception: pass if has_py2app: @@ -120,7 +120,7 @@ def run(self): try: import numpy numdir = os.path.dirname(numpy.__file__) -except: +except Exception: numdir = None if numdir is None: @@ -200,7 +200,7 @@ def run(self): # older versions of pip don't use the pipsession..? try: session = pip.download.PipSession() -except: +except Exception: session = None # parse_requirements() returns generator of pip.req.InstallRequirement objects if session: diff --git a/tests/common.py b/tests/common.py index 3ff80cbfe2..a13030b4e6 100644 --- a/tests/common.py +++ b/tests/common.py @@ -3,7 +3,7 @@ # https://github.com/pytorch/pytorch/issues/2575 # but with catboost, xgboost and lightgbm import sklearn -except: +except Exception: pass import os @@ -446,7 +446,7 @@ def create(**arrays): def try_convert(ar): try: return pa.array(ar) - except: + except Exception: return ar return vaex.from_dict({k: try_convert(v) for k, v in arrays.items()}) return create @@ -458,7 +458,7 @@ def create(**arrays): def try_convert(ar): try: return array_factory_arrow_chunked(ar) - except: + except Exception: return ar return vaex.from_dict({k: try_convert(v) for k, v in arrays.items()}) return create diff --git a/tests/jit_test.py b/tests/jit_test.py index b30cd0c30d..78505a13f4 100644 --- a/tests/jit_test.py +++ b/tests/jit_test.py @@ -3,7 +3,7 @@ try: import cupy -except: +except Exception: cupy = None diff --git a/tests/jupyter/async_test.py b/tests/jupyter/async_test.py index e3de3af40f..2fa0905812 100644 --- a/tests/jupyter/async_test.py +++ b/tests/jupyter/async_test.py @@ -109,7 +109,7 @@ async def run(): await asyncio.sleep(0.001/4) try: await future - except: + except Exception: pass asyncio.run(run())