Bind snapshot export height to exact nullifier checkpoint#112
Open
p0mvn wants to merge 1 commit into
Open
Conversation
Require exact index height matches for historical exports, enforce checkpoint offset usage in pir-export, and remove unreachable legacy rebuild code to eliminate mislabeled snapshot artifacts.
p0mvn
commented
Jun 5, 2026
Comment on lines
-38
to
-45
| /// Query the chain SDK for an active voting round. | ||
| /// | ||
| /// Returns `Some(round_id)` if a round is currently active, `None` otherwise. | ||
| /// Used to prevent rebuilds during active rounds which would invalidate proofs. | ||
| /// | ||
| /// Retained for historical reasons; see the module-level note above. | ||
| #[allow(dead_code)] | ||
| async fn check_active_round(chain_url: &str) -> Result<Option<String>> { |
Contributor
Author
There was a problem hiding this comment.
Note: deleted unused logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nf-server syncso floored offsets cannot be labeled as newer heightspir-exportparse full checkpoint(height, offset)and export only the committednullifiers.binprefix/snapshot/prepareexplicitly disabledTest plan
cargo test -p nf-server resolve_export_offsetcargo test -p pir-export --bin pir-export --features clicargo test -p nf-ingest exact_offset_requires_exact_heightcargo test -p nf-server --no-runnf-server syncover >20K heights and verify completion