Revert share commitment domain tag#87
Merged
Merged
Conversation
czarcas7ic
force-pushed
the
adam/revert-pr-59-share-commit-domain
branch
from
bded8a6 to
4b14cf2
Compare
p0mvn
approved these changes
May 20, 2026
czarcas7ic
force-pushed
the
adam/revert-pr-59-share-commit-domain
branch
from
4b14cf2 to
754cee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the per-share commitment domain tag so share commitments return to the prior five-input hash shape. The reverted branch keeps the later frozen-vector tests consistent with that hash output and preserves the existing ElGamal coordinate binding.
Validation: cargo fmt --manifest-path voting-circuits/Cargo.toml --all -- --check; cargo test --manifest-path voting-circuits/Cargo.toml --lib domain_tags; cargo test --manifest-path voting-circuits/Cargo.toml --lib share_commitment; cargo test --manifest-path voting-circuits/Cargo.toml --lib shares_hash_frozen_vector