Skip to content
This repository was archived by the owner on Dec 8, 2020. It is now read-only.
This repository was archived by the owner on Dec 8, 2020. It is now read-only.

Timber.add_context wrong typespec #348

@gabrielpra1

Description

@gabrielpra1

Timber.add_context has the typespec @spec add_context(map()) :: :ok, even though the function also accepts a keyword list as parameter.

This causes Dialyzer to throw misleading warnings:

The call 'Elixir.Timber':add_context([{'origin','tracker'},...]) will never return since the success typing is (map()) -> 'ok' and the contract is (map()) -> 'ok'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions