Skip to content

typecheck + all E2E red on main: vendored chat-sdk drifted Author / MessageData / Thread #1504

Description

@iroiro147

CI typecheck and every downstream E2E job is failing on main because of five pre-existing TypeScript errors — not from any one in-flight PR.

Reproduced just now on a clean checkout of origin/main (commit 6ad578ae) with npx tsc --noEmit -p packages/eve:

src/public/channels/chat-sdk/chatSdkChannel.ts(273,9): error TS2322
  Type 'Thread<unknown, unknown>' is not assignable to
  'string | SerializedThread | Thread<Record<string, unknown>, unknown>'.

src/public/channels/photon/inboundContent.test.ts(9,5): error TS2741
src/public/channels/photon/photonIMessageChannel.test.ts(45,7): error TS2741
src/public/channels/photon/photonIMessageChannel.test.ts(68,7): error TS2741
src/public/channels/photon/photonIMessageChannel.test.ts(90,7): error TS2741
  Property 'fullName' is missing in type '{ isBot; isMe; userId; userName }'
  but required in type 'Author'.

Probable cause

Recent chat-sdk dependency roll (vendored into .generated/compiled/chat/messages-BSoJG691.d.ts) added two requirements that existing callers don't yet satisfy:

  1. Author gained a required fullName: string.
  2. MessageData gained required formatted: FormattedContent (an mdast Root), metadata: MessageMetadata, and attachments: Attachment[].

The photon tests only stub the old minimal Author; adding fullName alone surfaces the remaining formatted/metadata/attachments mismatches, so the repair is larger than a stub tweak. The chatSdkChannel error at line 273 is independent — event.thread is Thread<unknown, unknown> but bridgeSend expects Thread<Record<string, unknown>, unknown> (or string, or SerializedThread).

Impact

Every downstream E2E job (e2e-local, e2e-postgres, e2e-vercel on every agent scenario) fails at pnpm run build:js, which underlines the typecheck error. This blocks every open PR, including #1497 (Version Packages).

Suggested fix

From the outside it looks like a mechanical update pass on:

  • packages/eve/src/public/channels/chat-sdk/chatSdkChannel.ts:273 — narrow event.thread with a runtime guard or a generic constraint that matches bridgeSend.
  • packages/eve/src/public/channels/photon/inboundContent.test.ts
  • packages/eve/src/public/channels/photon/photonIMessageChannel.test.ts
    — provide a richer Message fixture stub (fullName, formatted, metadata, attachments).

Happy to ship a small candidate repair if maintainers want contribution; flagging here first since these touch in-flight subsystems I don't own.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions