Sharing iP code quality feedback [for @verudex]

[soc-se-script]

@verudex We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Naming boolean variables/methods

No easy-to-detect issues 👍

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

No easy-to-detect issues 👍

Aspect: Recent Git Commit Messages

possible problems in commit e99971d:

Refactor code to eliminate magic values and reduce duplication

The codebase contains numerous magic numbers (4, 6, 8) and magic
strings ("1", "T", "D", "/by", etc.) scattered throughout. This
makes the code harder to understand and maintain. Additionally,
similar logic is duplicated across Parser and Hal classes.

Let's improve code quality by:
* Extract magic numbers as named constants (MARK_COMMAND_LENGTH, etc.)
* Replace magic strings with descriptive constants (DEADLINE_SEPARATOR,
  TODO_TYPE, DONE_MARKER)
* Extract repeated index validation logic into helper methods
* Create isCommandWithOptionalSpace() to eliminate duplicated parsing
* Break down Storage.parseTask() into smaller focused methods
* Add helper methods validateNonEmptyDescription() and createAndAddTask()

These refactorings make the code more maintainable because:
- Named constants document the meaning of values
- Helper methods reduce duplication and improve testability
- Smaller methods are easier to understand and modify
- Changes to command formats only require updating constants
- Consistent validation logic reduces bug potential

The code now follows better software engineering practices while
maintaining backward compatibility.

• body not wrapped at 72 characters: e.g., * Add helper methods validateNonEmptyDescription() and createAndAddTask()

Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).

Aspect: Binary files in repo

No easy-to-detect issues 👍

---

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@nus.edu.sg if you want to follow up on this post.