From f142f0863be4b62fa8deb6b78afe5fd57814a3c7 Mon Sep 17 00:00:00 2001
From: Karl von Randow <karl@xk72.com>
Date: Thu, 26 Mar 2026 08:42:55 +1300
Subject: [PATCH] Fix getColors() to return immutable empty map on fallback
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The fallback path returned a mutable HashMap which doesn’t line up with the VAppearance interface contract that getColors() returns a non-modifiable map.
---
 src/org/violetlib/vappearances/VAppearanceImpl.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/org/violetlib/vappearances/VAppearanceImpl.java b/src/org/violetlib/vappearances/VAppearanceImpl.java
index e218f4d..50548b8 100644
--- a/src/org/violetlib/vappearances/VAppearanceImpl.java
+++ b/src/org/violetlib/vappearances/VAppearanceImpl.java
@@ -12,7 +12,7 @@
 
 import java.awt.*;
 import java.io.IOException;
-import java.util.HashMap;
+import java.util.Collections;
 import java.util.Map;
 
 /**
@@ -85,7 +85,7 @@ public boolean isTinted()
     public @NotNull Map<String,Color> getColors()
     {
         Map<String,Color> colors = VAppearances.getSystemColorsForAppearance(name);
-        return colors != null ? colors : new HashMap<>();
+        return colors != null ? colors : Collections.emptyMap();
     }
 
     @Override