Skip to content

Commit 37d80d6

Browse files
vitorhugo-javavitorhugo-java
committed
fix(tests): add acceptedPrivacyPolicy and privacyPolicyAccepted to all test constructors
1 parent 2817afa commit 37d80d6

10 files changed

Lines changed: 27 additions & 27 deletions

‎src/test/java/com/jobtracker/integration/ApplicationControllerIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ void setUp() throws Exception {
5151
refreshTokenRepository.deleteAll();
5252
userRepository.deleteAll();
5353

54-
RegisterRequest reg = new RegisterRequest("App User", "appuser@example.com", "pass1234", "pass1234");
54+
RegisterRequest reg = new RegisterRequest("App User", "appuser@example.com", "pass1234", "pass1234", true);
5555
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
5656
.contentType(MediaType.APPLICATION_JSON)
5757
.content(objectMapper.writeValueAsString(reg)))

‎src/test/java/com/jobtracker/integration/AuthControllerIT.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ void cleanDb() {
6868

6969
@Test
7070
void register_shouldReturn201_setRefreshTokenCookie_andReturnAccessToken() throws Exception {
71-
RegisterRequest request = new RegisterRequest("Test User", "register@example.com", "pass1234", "pass1234");
71+
RegisterRequest request = new RegisterRequest("Test User", "register@example.com", "pass1234", "pass1234", true);
7272

7373
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
7474
.contentType(MediaType.APPLICATION_JSON)
@@ -99,7 +99,7 @@ void register_shouldReturn201_setRefreshTokenCookie_andReturnAccessToken() throw
9999

100100
@Test
101101
void register_shouldReturn409_whenEmailAlreadyExists() throws Exception {
102-
RegisterRequest request = new RegisterRequest("Test User", "duplicate@example.com", "pass1234", "pass1234");
102+
RegisterRequest request = new RegisterRequest("Test User", "duplicate@example.com", "pass1234", "pass1234", true);
103103

104104
mockMvc.perform(post("/api/v1/auth/register")
105105
.contentType(MediaType.APPLICATION_JSON)
@@ -114,7 +114,7 @@ void register_shouldReturn409_whenEmailAlreadyExists() throws Exception {
114114

115115
@Test
116116
void register_shouldReturn400_whenPasswordsDoNotMatch() throws Exception {
117-
RegisterRequest request = new RegisterRequest("Test User", "mismatch@example.com", "pass1234", "different");
117+
RegisterRequest request = new RegisterRequest("Test User", "mismatch@example.com", "pass1234", "different", true);
118118

119119
mockMvc.perform(post("/api/v1/auth/register")
120120
.contentType(MediaType.APPLICATION_JSON)
@@ -125,7 +125,7 @@ void register_shouldReturn400_whenPasswordsDoNotMatch() throws Exception {
125125
@Test
126126
void login_shouldReturn200_setRefreshTokenCookie_andReturnAccessToken() throws Exception {
127127
// First register
128-
RegisterRequest reg = new RegisterRequest("Login User", "login@example.com", "pass1234", "pass1234");
128+
RegisterRequest reg = new RegisterRequest("Login User", "login@example.com", "pass1234", "pass1234", true);
129129
mockMvc.perform(post("/api/v1/auth/register")
130130
.contentType(MediaType.APPLICATION_JSON)
131131
.content(objectMapper.writeValueAsString(reg)));
@@ -164,7 +164,7 @@ void login_shouldReturn401_whenBadCredentials() throws Exception {
164164
@Test
165165
void refresh_shouldReadFromCookie_returnNewAccessToken_andRotateRefreshTokenCookie() throws Exception {
166166
// Register to get initial tokens
167-
RegisterRequest reg = new RegisterRequest("Refresh User", "refresh@example.com", "pass1234", "pass1234");
167+
RegisterRequest reg = new RegisterRequest("Refresh User", "refresh@example.com", "pass1234", "pass1234", true);
168168
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
169169
.contentType(MediaType.APPLICATION_JSON)
170170
.content(objectMapper.writeValueAsString(reg)))
@@ -213,7 +213,7 @@ void refresh_shouldReturn401_whenRefreshTokenIsInvalid() throws Exception {
213213
@Test
214214
void logout_shouldClearRefreshTokenCookie() throws Exception {
215215
// Register
216-
RegisterRequest reg = new RegisterRequest("Logout User", "logout@example.com", "pass1234", "pass1234");
216+
RegisterRequest reg = new RegisterRequest("Logout User", "logout@example.com", "pass1234", "pass1234", true);
217217
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
218218
.contentType(MediaType.APPLICATION_JSON)
219219
.content(objectMapper.writeValueAsString(reg)))
@@ -247,7 +247,7 @@ void logout_shouldClearRefreshTokenCookie() throws Exception {
247247

248248
@Test
249249
void me_shouldReturn200_whenAuthenticated() throws Exception {
250-
RegisterRequest reg = new RegisterRequest("Me User", "me@example.com", "pass1234", "pass1234");
250+
RegisterRequest reg = new RegisterRequest("Me User", "me@example.com", "pass1234", "pass1234", true);
251251
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
252252
.contentType(MediaType.APPLICATION_JSON)
253253
.content(objectMapper.writeValueAsString(reg)))
@@ -271,7 +271,7 @@ void me_shouldReturn403_whenNotAuthenticated() throws Exception {
271271

272272
@Test
273273
void me_shouldReturn403_whenTokenDoesNotContainRoleUser() throws Exception {
274-
RegisterRequest reg = new RegisterRequest("Admin Token User", "admin-token@example.com", "pass1234", "pass1234");
274+
RegisterRequest reg = new RegisterRequest("Admin Token User", "admin-token@example.com", "pass1234", "pass1234", true);
275275
mockMvc.perform(post("/api/v1/auth/register")
276276
.contentType(MediaType.APPLICATION_JSON)
277277
.content(objectMapper.writeValueAsString(reg)))
@@ -290,7 +290,7 @@ void me_shouldReturn403_whenTokenDoesNotContainRoleUser() throws Exception {
290290

291291
@Test
292292
void sendTestEmail_shouldReturn200_whenAuthenticated() throws Exception {
293-
RegisterRequest reg = new RegisterRequest("Mail User", "mail-user@example.com", "pass1234", "pass1234");
293+
RegisterRequest reg = new RegisterRequest("Mail User", "mail-user@example.com", "pass1234", "pass1234", true);
294294
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
295295
.contentType(MediaType.APPLICATION_JSON)
296296
.content(objectMapper.writeValueAsString(reg)))
@@ -321,7 +321,7 @@ void forgotPassword_shouldReturn200_regardlessOfEmailExistence() throws Exceptio
321321

322322
@Test
323323
void updateProfile_shouldReturn200_whenAuthenticated() throws Exception {
324-
RegisterRequest reg = new RegisterRequest("Profile User", "profile@example.com", "pass1234", "pass1234");
324+
RegisterRequest reg = new RegisterRequest("Profile User", "profile@example.com", "pass1234", "pass1234", true);
325325
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
326326
.contentType(MediaType.APPLICATION_JSON)
327327
.content(objectMapper.writeValueAsString(reg)))
@@ -340,7 +340,7 @@ void updateProfile_shouldReturn200_whenAuthenticated() throws Exception {
340340

341341
@Test
342342
void changePassword_shouldReturn200_andAllowLoginWithNewPassword() throws Exception {
343-
RegisterRequest reg = new RegisterRequest("Password User", "password-change@example.com", "pass1234", "pass1234");
343+
RegisterRequest reg = new RegisterRequest("Password User", "password-change@example.com", "pass1234", "pass1234", true);
344344
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
345345
.contentType(MediaType.APPLICATION_JSON)
346346
.content(objectMapper.writeValueAsString(reg)))
@@ -365,7 +365,7 @@ void changePassword_shouldReturn200_andAllowLoginWithNewPassword() throws Except
365365

366366
@Test
367367
void changePassword_shouldReturn400_whenCurrentPasswordIsInvalid() throws Exception {
368-
RegisterRequest reg = new RegisterRequest("Password User", "password-invalid@example.com", "pass1234", "pass1234");
368+
RegisterRequest reg = new RegisterRequest("Password User", "password-invalid@example.com", "pass1234", "pass1234", true);
369369
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
370370
.contentType(MediaType.APPLICATION_JSON)
371371
.content(objectMapper.writeValueAsString(reg)))
@@ -383,7 +383,7 @@ void changePassword_shouldReturn400_whenCurrentPasswordIsInvalid() throws Except
383383

384384
@Test
385385
void passkeyLoginOptions_shouldReturnFallbackWhenUserHasNoPasskeys() throws Exception {
386-
RegisterRequest reg = new RegisterRequest("No Passkey User", "no-passkey@example.com", "pass1234", "pass1234");
386+
RegisterRequest reg = new RegisterRequest("No Passkey User", "no-passkey@example.com", "pass1234", "pass1234", true);
387387
mockMvc.perform(post("/api/v1/auth/register")
388388
.contentType(MediaType.APPLICATION_JSON)
389389
.content(objectMapper.writeValueAsString(reg)))
@@ -407,7 +407,7 @@ void passkeyRegisterOptions_shouldReturn403WhenNotAuthenticated() throws Excepti
407407

408408
@Test
409409
void passkeyMe_shouldReturnHasPasskeysFalseByDefault() throws Exception {
410-
RegisterRequest reg = new RegisterRequest("Passkey Status User", "passkey-status@example.com", "pass1234", "pass1234");
410+
RegisterRequest reg = new RegisterRequest("Passkey Status User", "passkey-status@example.com", "pass1234", "pass1234", true);
411411
MvcResult regResult = mockMvc.perform(post("/api/v1/auth/register")
412412
.contentType(MediaType.APPLICATION_JSON)
413413
.content(objectMapper.writeValueAsString(reg)))

‎src/test/java/com/jobtracker/integration/AuthRateLimiterIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class AuthRateLimiterIT extends AbstractIntegrationTest {
2525

2626
@Test
2727
void login_shouldReturn429_whenRateLimitIsExceeded() throws Exception {
28-
RegisterRequest registerRequest = new RegisterRequest("Rate Limit User", "ratelimit@example.com", "pass1234", "pass1234");
28+
RegisterRequest registerRequest = new RegisterRequest("Rate Limit User", "ratelimit@example.com", "pass1234", "pass1234", true);
2929
LoginRequest loginRequest = new LoginRequest("ratelimit@example.com", "pass1234");
3030

3131
mockMvc.perform(post("/api/v1/auth/register")

‎src/test/java/com/jobtracker/integration/GamificationControllerIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ void getAchievements_shouldReturnCatalog() throws Exception {
121121
}
122122

123123
private String registerAndGetAccessToken(String email) throws Exception {
124-
RegisterRequest request = new RegisterRequest("Gamification User", email, "pass1234", "pass1234");
124+
RegisterRequest request = new RegisterRequest("Gamification User", email, "pass1234", "pass1234", true);
125125
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
126126
.contentType(MediaType.APPLICATION_JSON)
127127
.content(objectMapper.writeValueAsString(request)))

‎src/test/java/com/jobtracker/integration/GoogleDriveControllerIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ void setUp() throws Exception {
8787
userInterviewMetricsRepository.deleteAll();
8888
userRepository.deleteAll();
8989

90-
RegisterRequest reg = new RegisterRequest("Drive User", "driveuser@example.com", "pass1234", "pass1234");
90+
RegisterRequest reg = new RegisterRequest("Drive User", "driveuser@example.com", "pass1234", "pass1234", true);
9191
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
9292
.contentType(MediaType.APPLICATION_JSON)
9393
.content(objectMapper.writeValueAsString(reg)))

‎src/test/java/com/jobtracker/integration/GptOAuthFlowIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ void googleDriveCallback_shouldRemainPublic() throws Exception {
223223
}
224224

225225
private AuthResponse registerUser(String email, String password) throws Exception {
226-
RegisterRequest request = new RegisterRequest("GPT User", email, password, password);
226+
RegisterRequest request = new RegisterRequest("GPT User", email, password, password, true);
227227
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
228228
.contentType(MediaType.APPLICATION_JSON)
229229
.content(objectMapper.writeValueAsString(request)))

‎src/test/java/com/jobtracker/integration/mcp/McpAuthIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ void setUp() throws Exception {
5959
refreshTokenRepository.deleteAll();
6060
userRepository.deleteAll();
6161

62-
RegisterRequest reg = new RegisterRequest("MCP Test User", "mcp-test@example.com", "pass1234", "pass1234");
62+
RegisterRequest reg = new RegisterRequest("MCP Test User", "mcp-test@example.com", "pass1234", "pass1234", true);
6363
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
6464
.contentType(MediaType.APPLICATION_JSON)
6565
.content(objectMapper.writeValueAsString(reg)))

‎src/test/java/com/jobtracker/integration/mcp/McpToolsIT.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ void setUp() throws Exception {
101101
refreshTokenRepository.deleteAll();
102102
userRepository.deleteAll();
103103

104-
RegisterRequest reg = new RegisterRequest("Tools Test User", "tools-test@example.com", "pass1234", "pass1234");
104+
RegisterRequest reg = new RegisterRequest("Tools Test User", "tools-test@example.com", "pass1234", "pass1234", true);
105105
MvcResult result = mockMvc.perform(post("/api/v1/auth/register")
106106
.contentType(MediaType.APPLICATION_JSON)
107107
.content(objectMapper.writeValueAsString(reg)))

‎src/test/java/com/jobtracker/unit/AuthServiceTest.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class AuthServiceTest {
5656

5757
@Test
5858
void register_shouldReturnAuthResponse_whenValidRequest() {
59-
RegisterRequest request = new RegisterRequest("John", "john@example.com", "pass1234", "pass1234");
59+
RegisterRequest request = new RegisterRequest("John", "john@example.com", "pass1234", "pass1234", true);
6060
User savedUser = buildUser(USER_UUID, "john@example.com");
6161

6262
when(userRepository.existsByEmail(request.email())).thenReturn(false);
@@ -71,7 +71,7 @@ void register_shouldReturnAuthResponse_whenValidRequest() {
7171
"john@example.com",
7272
LocalTime.of(9, 0),
7373
Set.of("USER"),
74-
false));
74+
false, true));
7575

7676
AuthResponse result = authService.register(request);
7777

@@ -85,15 +85,15 @@ void register_shouldReturnAuthResponse_whenValidRequest() {
8585

8686
@Test
8787
void register_shouldThrow_whenPasswordsDoNotMatch() {
88-
RegisterRequest request = new RegisterRequest("John", "john@example.com", "pass1234", "different");
88+
RegisterRequest request = new RegisterRequest("John", "john@example.com", "pass1234", "different", true);
8989
assertThatThrownBy(() -> authService.register(request))
9090
.isInstanceOf(BadRequestException.class)
9191
.hasMessageContaining("Passwords do not match");
9292
}
9393

9494
@Test
9595
void register_shouldThrow_whenEmailAlreadyExists() {
96-
RegisterRequest request = new RegisterRequest("John", "john@example.com", "pass1234", "pass1234");
96+
RegisterRequest request = new RegisterRequest("John", "john@example.com", "pass1234", "pass1234", true);
9797
when(userRepository.existsByEmail(request.email())).thenReturn(true);
9898
assertThatThrownBy(() -> authService.register(request))
9999
.isInstanceOf(ConflictException.class)
@@ -115,7 +115,7 @@ void login_shouldReturnAuthResponse_whenValidCredentials() {
115115
"john@example.com",
116116
LocalTime.of(9, 0),
117117
Set.of("USER"),
118-
false));
118+
false, true));
119119

120120
AuthResponse result = authService.login(request);
121121

‎src/test/java/com/jobtracker/unit/mcp/McpProfileToolsTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ void currentUser_serializesAuthenticatedUser() throws Exception {
6262
"john@example.com",
6363
java.time.LocalTime.of(19, 0),
6464
java.util.Set.of("USER", "BETA"),
65-
true);
65+
true, true);
6666
when(securityUtils.getCurrentUser()).thenReturn(user);
6767
when(authMapper.toUserResponse(user)).thenReturn(expected);
6868

0 commit comments

Comments
 (0)