|
| 1 | +"""Tests for coverage gaps in _bridge, receiver, sd, transport, and tp modules.""" |
| 2 | + |
| 3 | +from __future__ import annotations |
| 4 | + |
| 5 | +import asyncio |
| 6 | +import threading |
| 7 | +from types import SimpleNamespace |
| 8 | +from unittest.mock import MagicMock, patch |
| 9 | + |
| 10 | +import pytest |
| 11 | + |
| 12 | +from opensomeip.message import Message |
| 13 | +from opensomeip.receiver import MessageReceiver |
| 14 | +from opensomeip.sd import SdClient, SdConfig, SdServer |
| 15 | +from opensomeip.transport import Endpoint, UdpTransport |
| 16 | +from opensomeip.types import MessageId, MessageType, ReturnCode |
| 17 | + |
| 18 | +# --------------------------------------------------------------------------- |
| 19 | +# 1. _bridge.py — from_cpp_* functions |
| 20 | +# --------------------------------------------------------------------------- |
| 21 | + |
| 22 | + |
| 23 | +class TestBridgeFromCpp: |
| 24 | + def test_from_cpp_endpoint(self) -> None: |
| 25 | + from opensomeip._bridge import from_cpp_endpoint |
| 26 | + |
| 27 | + mock = SimpleNamespace(address="127.0.0.1", port=8080) |
| 28 | + ep = from_cpp_endpoint(mock) |
| 29 | + assert ep.ip == "127.0.0.1" |
| 30 | + assert ep.port == 8080 |
| 31 | + |
| 32 | + def test_from_cpp_message_id(self) -> None: |
| 33 | + from opensomeip._bridge import from_cpp_message_id |
| 34 | + |
| 35 | + mock = SimpleNamespace(service_id=0x1234, method_id=0x0001) |
| 36 | + mid = from_cpp_message_id(mock) |
| 37 | + assert mid.service_id == 0x1234 |
| 38 | + assert mid.method_id == 0x0001 |
| 39 | + |
| 40 | + def test_from_cpp_request_id(self) -> None: |
| 41 | + from opensomeip._bridge import from_cpp_request_id |
| 42 | + |
| 43 | + mock = SimpleNamespace(client_id=0x0010, session_id=0x0001) |
| 44 | + rid = from_cpp_request_id(mock) |
| 45 | + assert rid.client_id == 0x0010 |
| 46 | + assert rid.session_id == 0x0001 |
| 47 | + |
| 48 | + def test_from_cpp_message(self) -> None: |
| 49 | + from opensomeip._bridge import from_cpp_message |
| 50 | + |
| 51 | + mock = SimpleNamespace( |
| 52 | + message_id=SimpleNamespace(service_id=0x1234, method_id=0x0001), |
| 53 | + request_id=SimpleNamespace(client_id=0x0010, session_id=0x0001), |
| 54 | + message_type=0, # REQUEST |
| 55 | + return_code=0, # E_OK |
| 56 | + interface_version=1, |
| 57 | + payload=b"test", |
| 58 | + ) |
| 59 | + msg = from_cpp_message(mock) |
| 60 | + assert msg.message_id.service_id == 0x1234 |
| 61 | + assert msg.message_id.method_id == 0x0001 |
| 62 | + assert msg.request_id.client_id == 0x0010 |
| 63 | + assert msg.request_id.session_id == 0x0001 |
| 64 | + assert msg.message_type == MessageType.REQUEST |
| 65 | + assert msg.return_code == ReturnCode.E_OK |
| 66 | + assert msg.interface_version == 1 |
| 67 | + assert msg.payload == b"test" |
| 68 | + |
| 69 | + def test_from_cpp_service_instance(self) -> None: |
| 70 | + from opensomeip._bridge import from_cpp_service_instance |
| 71 | + |
| 72 | + mock = SimpleNamespace( |
| 73 | + service_id=0x1234, |
| 74 | + instance_id=0x0001, |
| 75 | + major_version=2, |
| 76 | + minor_version=3, |
| 77 | + ) |
| 78 | + svc = from_cpp_service_instance(mock) |
| 79 | + assert svc.service_id == 0x1234 |
| 80 | + assert svc.instance_id == 0x0001 |
| 81 | + assert svc.major_version == 2 |
| 82 | + assert svc.minor_version == 3 |
| 83 | + |
| 84 | + |
| 85 | +# --------------------------------------------------------------------------- |
| 86 | +# 2. receiver.py — _ensure_async_queue (no loop), _put_async fallback, __anext__ |
| 87 | +# --------------------------------------------------------------------------- |
| 88 | + |
| 89 | + |
| 90 | +class TestReceiverCoverage: |
| 91 | + def test_ensure_async_queue_when_no_running_loop(self) -> None: |
| 92 | + """_ensure_async_queue sets _loop to None when get_running_loop raises.""" |
| 93 | + r = MessageReceiver() |
| 94 | + # Call _ensure_async_queue from a thread (no running event loop) |
| 95 | + result: list[object] = [] |
| 96 | + |
| 97 | + def in_thread() -> None: |
| 98 | + q = r._ensure_async_queue() |
| 99 | + result.append(q) |
| 100 | + result.append(r._loop) |
| 101 | + |
| 102 | + t = threading.Thread(target=in_thread) |
| 103 | + t.start() |
| 104 | + t.join() |
| 105 | + |
| 106 | + assert len(result) == 2 |
| 107 | + assert result[0] is not None |
| 108 | + assert result[1] is None # _loop is None when no running loop |
| 109 | + |
| 110 | + def test_put_async_fallback_when_no_loop(self) -> None: |
| 111 | + """_put_async fallback path when loop is None or not running.""" |
| 112 | + r = MessageReceiver() |
| 113 | + # Initialize async queue without a running loop (so _loop is None) |
| 114 | + r._ensure_async_queue() |
| 115 | + assert r._loop is None |
| 116 | + # _put_async should use put_nowait fallback (lines 55-58) |
| 117 | + r._put_async(Message(payload=b"x")) |
| 118 | + # Verify message made it to async queue via fallback path |
| 119 | + r.close() |
| 120 | + # Run async consumer to drain the async queue |
| 121 | + collected: list[Message] = [] |
| 122 | + |
| 123 | + async def consume() -> None: |
| 124 | + aiter = r.__aiter__() |
| 125 | + try: |
| 126 | + while True: |
| 127 | + msg = await aiter.__anext__() |
| 128 | + collected.append(msg) |
| 129 | + except StopAsyncIteration: |
| 130 | + pass |
| 131 | + |
| 132 | + asyncio.run(consume()) |
| 133 | + assert len(collected) == 1 |
| 134 | + assert collected[0].payload == b"x" |
| 135 | + |
| 136 | + def test_put_async_when_async_queue_none(self) -> None: |
| 137 | + """_put_async returns early when _async_queue is None.""" |
| 138 | + r = MessageReceiver() |
| 139 | + # Never call _ensure_async_queue, so _async_queue stays None |
| 140 | + r._put_async(Message(payload=b"x")) # should not raise |
| 141 | + assert r._async_queue is None |
| 142 | + |
| 143 | + @pytest.mark.asyncio |
| 144 | + async def test_anext_yields_messages(self) -> None: |
| 145 | + """__anext__ yields messages and raises StopAsyncIteration on sentinel.""" |
| 146 | + r = MessageReceiver() |
| 147 | + aiter = r.__aiter__() |
| 148 | + r.put(Message(payload=b"first")) |
| 149 | + r.put(Message(payload=b"second")) |
| 150 | + r.close() |
| 151 | + |
| 152 | + msgs: list[Message] = [] |
| 153 | + with pytest.raises(StopAsyncIteration): |
| 154 | + while True: |
| 155 | + msg = await aiter.__anext__() |
| 156 | + msgs.append(msg) |
| 157 | + |
| 158 | + assert len(msgs) == 2 |
| 159 | + assert msgs[0].payload == b"first" |
| 160 | + assert msgs[1].payload == b"second" |
| 161 | + |
| 162 | + |
| 163 | +# --------------------------------------------------------------------------- |
| 164 | +# 3. sd.py — config, get_statistics, async context manager |
| 165 | +# --------------------------------------------------------------------------- |
| 166 | + |
| 167 | + |
| 168 | +@pytest.fixture() |
| 169 | +def sd_config() -> SdConfig: |
| 170 | + return SdConfig( |
| 171 | + multicast_endpoint=Endpoint("239.1.1.1", 30490), |
| 172 | + unicast_endpoint=Endpoint("192.168.1.100", 30490), |
| 173 | + ) |
| 174 | + |
| 175 | + |
| 176 | +class TestSdCoverage: |
| 177 | + def test_sd_server_config_property(self, sd_config: SdConfig) -> None: |
| 178 | + server = SdServer(sd_config) |
| 179 | + assert server.config is sd_config |
| 180 | + |
| 181 | + def test_sd_server_get_statistics_returns_none(self, sd_config: SdConfig) -> None: |
| 182 | + """get_statistics returns None when C++ extension is unavailable.""" |
| 183 | + server = SdServer(sd_config) |
| 184 | + # When ext is None, _cpp is None, so get_statistics returns None |
| 185 | + result = server.get_statistics() |
| 186 | + assert result is None |
| 187 | + |
| 188 | + def test_sd_client_config_property(self, sd_config: SdConfig) -> None: |
| 189 | + client = SdClient(sd_config) |
| 190 | + assert client.config is sd_config |
| 191 | + |
| 192 | + def test_sd_client_get_statistics_returns_none(self, sd_config: SdConfig) -> None: |
| 193 | + """get_statistics returns None when C++ extension is unavailable.""" |
| 194 | + client = SdClient(sd_config) |
| 195 | + result = client.get_statistics() |
| 196 | + assert result is None |
| 197 | + |
| 198 | + @pytest.mark.asyncio |
| 199 | + async def test_sd_client_async_context_manager(self, sd_config: SdConfig) -> None: |
| 200 | + """SdClient async context manager (__aenter__/__aexit__).""" |
| 201 | + async with SdClient(sd_config) as client: |
| 202 | + assert client.is_running is True |
| 203 | + assert client.is_running is False |
| 204 | + |
| 205 | + |
| 206 | +# --------------------------------------------------------------------------- |
| 207 | +# 4. transport.py — _NativeTransportListener (get_ext None), send source_endpoint |
| 208 | +# --------------------------------------------------------------------------- |
| 209 | + |
| 210 | + |
| 211 | +class TestTransportCoverage: |
| 212 | + def test_native_transport_listener_cpp_none_when_ext_unavailable(self) -> None: |
| 213 | + """_NativeTransportListener has _cpp=None when get_ext returns None.""" |
| 214 | + with patch("opensomeip.transport.get_ext", return_value=None): |
| 215 | + from opensomeip.transport import _NativeTransportListener |
| 216 | + |
| 217 | + receiver = MessageReceiver() |
| 218 | + listener = _NativeTransportListener(receiver) |
| 219 | + assert listener.cpp is None |
| 220 | + |
| 221 | + def test_send_uses_source_endpoint_when_no_endpoint_or_remote(self) -> None: |
| 222 | + """send() uses message.source_endpoint when endpoint and remote are None.""" |
| 223 | + t = UdpTransport(Endpoint("0.0.0.0", 0)) |
| 224 | + t.start() |
| 225 | + mock_cpp = MagicMock() |
| 226 | + t._cpp = mock_cpp |
| 227 | + msg = Message(payload=b"test") |
| 228 | + msg.source_endpoint = Endpoint("192.168.1.1", 30490) |
| 229 | + # Patch to_cpp_* when extension may be unavailable |
| 230 | + mock_cpp_msg = MagicMock() |
| 231 | + mock_cpp_ep = MagicMock() |
| 232 | + with ( |
| 233 | + patch("opensomeip.transport.to_cpp_message", return_value=mock_cpp_msg), |
| 234 | + patch("opensomeip.transport.to_cpp_endpoint", return_value=mock_cpp_ep), |
| 235 | + ): |
| 236 | + t.send(msg) |
| 237 | + mock_cpp.send_message.assert_called_once_with(mock_cpp_msg, mock_cpp_ep) |
| 238 | + t.stop() |
| 239 | + |
| 240 | + |
| 241 | +# --------------------------------------------------------------------------- |
| 242 | +# 5. tp.py — pure-Python large message segmentation, get_statistics |
| 243 | +# --------------------------------------------------------------------------- |
| 244 | + |
| 245 | + |
| 246 | +class TestTpCoverage: |
| 247 | + def test_send_large_message_pure_python_path(self) -> None: |
| 248 | + """Send message larger than MTU uses pure-Python segmentation when C++ unavailable.""" |
| 249 | + t = UdpTransport(Endpoint("0.0.0.0", 0)) |
| 250 | + t.start() |
| 251 | + tp = __import__("opensomeip.tp", fromlist=["TpManager"]).TpManager |
| 252 | + manager = tp(t, mtu=100) |
| 253 | + manager.start() |
| 254 | + # With ext possibly available, we need to force pure-Python path. |
| 255 | + # When ext is None, _cpp is None, so the else branch (lines 112-126) runs. |
| 256 | + # When ext is available, the try block runs. To hit pure-Python path, |
| 257 | + # we can patch _cpp to None. |
| 258 | + with patch.object(manager, "_cpp", None): |
| 259 | + msg = Message( |
| 260 | + message_id=MessageId(0x1234, 0x0001), |
| 261 | + payload=b"x" * 250, |
| 262 | + ) |
| 263 | + manager.send(msg) |
| 264 | + manager.stop() |
| 265 | + t.stop() |
| 266 | + |
| 267 | + def test_get_statistics_returns_none(self) -> None: |
| 268 | + """get_statistics returns None when C++ extension is unavailable.""" |
| 269 | + t = UdpTransport(Endpoint("0.0.0.0", 0)) |
| 270 | + t.start() |
| 271 | + from opensomeip.tp import TpManager |
| 272 | + |
| 273 | + manager = TpManager(t) |
| 274 | + with patch.object(manager, "_cpp", None): |
| 275 | + result = manager.get_statistics() |
| 276 | + assert result is None |
| 277 | + t.stop() |
0 commit comments