Draft: Feature: Signals to update vector index on page publish#30
Open
Morsey187 wants to merge 2 commits into
Open
Draft: Feature: Signals to update vector index on page publish#30Morsey187 wants to merge 2 commits into
Morsey187 wants to merge 2 commits into
Conversation
Member
|
Discussed this with Ben separately but copying some of those comments here for reference. This implementation has raised a few potential challenging points we might need to address before we can finalise this. Right now, this does a full index rebuild on save, which as Ben identified can potentially be very slow. Ideally, we would only update the current page when saving, but to do this we need to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new env
WAGTAIL_VECTOR_INDEX_UPDATE_ON_PUBLISHto enable registering all pages with aVectorIndexedMixinto wagtail's page_published signal.