Create the PageVectorIndexedMixin class#41
Draft
mgax wants to merge 1 commit into
Draft
Conversation
It's an explicit way to include Wagtail-specific behaviour (i.e. use of `PageVectorIndex` instead of `ModelVectorIndex`) when defining a Page model. This also helps with type annotations for the return value of the `get_vector_index()` method.
Member
Author
|
I have this WIP patch to wagtail-vector-index lying around my repo since two weeks ago. It's a bit of a refactoring of the (page) model mixin class, to make typing easier, and make the code a bit more robust, but it introduces a breaking change. Not sure if it's worth pursuing, and I don't have bandwidth for it, so I've made it into a draft PR, in case somebody else finds it useful. If not, feel free to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an explicit way to include Wagtail-specific behaviour (i.e. use of
PageVectorIndexinstead ofModelVectorIndex) when defining a Page model. This also helps with type annotations for the return value of theget_vector_index()method.