Skip to content

Possible soundness issue in ChildImp::wait #20

@gigaroby

Description

@gigaroby

While conducting an internal unsafe review, we identified a possible soundness issue in ChildImp::wait

pub async fn wait(&mut self) -> Result<ExitStatus> {
let handles = self.handles.clone();
spawn_blocking(|| Self::wait_imp(handles, INFINITE)).await??;
self.inner.wait().await
}

This function and the one below call the Clone impl that appears to undermine the unsafe Drop impl on self.handles.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions