fix(build): stage Whisper runtime in macOS CI jobs#333
Merged
Conversation
1 task
Collaborator
Author
|
Manual build validation passed on this branch via Actions run 24902953791: build-macos, build-windows, and build-linux all completed successfully. That gives this workflow-only fix enough evidence for review, so I moved it out of draft. I am still keeping the scope narrow to the macOS packaging path behind #220 rather than claiming the Windows reports are fixed too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a focused fix for the macOS packaging path behind auto-captions. The GitHub macOS build and release jobs were still calling
npm run build:native-helpers, which skips the bundled Whisper runtime. This switches those jobs tonpm run build:platform-native-helpersso packaged macOS artifacts stagewhisper-clibefore Electron Builder runs.Motivation
Issue #220 reports auto-captions failing immediately after pressing Generate. On current
main, source builds already runbuild:platform-native-helpers, but the macOS CI packaging jobs did not, so packaged macOS builds could ship without the Whisper runtime and fail before transcription starts. I kept this scoped to the macOS packaging path only; the Windows reports in #220 may still need separate investigation.Type of Change
Related Issue(s)
Related: #220
Screenshots / Video
Not included. This is a workflow-only change.
Testing Guide
electron/ipc/captions/generate.tsand the packaging workflows onmainnpm run build:platform-native-helpers.github/workflows/build.ymland.github/workflows/release.ymlwere still usingnpm run build:native-helpersnpm run build:platform-native-helpersgit diff --checkbuild:platform-native-helpersChecklist