refactor(export): wire lightning route policy#555
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds Windows native static-layout export preference to ModernVideoExporter. The export method now defers streaming native encoder startup when a backend policy function indicates static-layout should be attempted first. A new test validates this fallback routing behavior on Windows. ChangesNative static-layout routing for Windows
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ModernVideoExporterstartup routing.autoexports so native static-layout can be probed first.autoreturns the static-layout result without starting Breeze/WebCodecs when that path succeeds.Verification
npm test -- src/lib/exporter/modernVideoExporter.fallback.test.ts src/lib/exporter/backendPolicy.test.tsnpx tsc --noEmitnpx biome check --formatter-enabled=false src/lib/exporter/modernVideoExporter.ts src/lib/exporter/modernVideoExporter.fallback.test.ts src/lib/exporter/backendPolicy.ts src/lib/exporter/backendPolicy.test.tsgit diff --checkNotes
modernVideoExporterrouting; no native helper, CUDA, packaging, or broad fix(export): route Windows auto through native GPU planner #504 merge.tscunder local CPU contention, so the final test verification was run isolated.Summary by CodeRabbit