fix(export): gate packaged cuda audio fallback#559
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR refactors NVIDIA CUDA auto-candidate state handling by distinguishing between "enabled" and "active" flags. The implementation adjusts the env-disabled early return and audio fallback validation logic accordingly. A new test case verifies the updated behavior when CUDA export is enabled in packaged mode. ChangesNVIDIA CUDA Auto-Candidate State Distinction
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
RECORDLY_NVIDIA_CUDA_FORCE_VIDEO_ONLYor the explicit audio override is set.Why
This is a small #504 follow-up. In packaged builds, the auto-candidate path can safely try CUDA with shared mux fallback, but explicit CUDA should not inherit that audio bypass merely because the app is packaged. This keeps packaged
.exebehavior narrower and less likely to accept an unsafe CUDA audio route.This PR intentionally avoids the broader #504 route planner and CUDA compositor changes.
Verification
Summary by CodeRabbit
Tests
Bug Fixes