fix(recording): abort prune on unreadable project#561
Conversation
📝 WalkthroughWalkthroughError handling in ChangesPruning error handling
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Type of Change
Related Issue(s)
Why
This is a small #504 extraction. If a saved project is unreadable, pruning cannot safely know which recording paths are still protected by that project. Failing closed avoids deleting recordings that may still be referenced.
This PR intentionally does not include the broader #504 native route, CUDA compositor, binary manifest, or dev launcher changes.
Verification
npm test -- electron/ipc/recording/prune.test.tsnpx tsc --noEmitnpx biome check --formatter-enabled=false electron/ipc/recording/prune.ts electron/ipc/recording/prune.test.tsgit diff --check