fix(export): keep Windows auto off static layout first#582
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughWindows "auto" backend preference now routes to streaming by default; a new feature flag disables native-static-layout priority for that case. ModernVideoExporter centralizes native-static-layout eligibility into a single flag combining Breeze preference or NVIDIA CUDA opt-in, and replaces scattered backend checks with this flag at both probe points. Tests verify Windows auto streams natively without static-layout steps and document CUDA-enabled static scenarios. ChangesBackend Routing and Native-Static-Layout Gating
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/exporter/modernVideoExporter.ts`:
- Around line 385-391: The two flags are inconsistent: update the computation of
shouldTryNativeStaticLayout to include the same
shouldPreferNativeStaticLayoutBeforeBreeze(runtimePlatform, backendPreference)
check used by shouldDeferNativeEncoderStart so both follow the same conditions;
specifically, in the block where shouldTryNativeStaticLayout is set, add the OR
condition with shouldPreferNativeStaticLayoutBeforeBreeze(runtimePlatform,
backendPreference) (keeping the existing checks against backendPreference ===
"breeze" and this.config.experimentalNvidiaCudaExport === true) so both flags
remain aligned when the feature flag toggles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 42ea93cf-38f1-4c82-8819-c3c5a8b74261
📒 Files selected for processing (4)
src/lib/exporter/backendPolicy.test.tssrc/lib/exporter/backendPolicy.tssrc/lib/exporter/modernVideoExporter.fallback.test.tssrc/lib/exporter/modernVideoExporter.ts
Description
Keep Windows
autoLightning exports on the streaming native/Breeze route instead of probing native static-layout before the stable path.Motivation
Issue #581 reports 1.3.0 Windows 10 Lightning exports getting stuck at
Prepare. The current Windowsautoroute probes native static-layout before Breeze/WebCodecs, which can hold the UI in the preparing phase before the stable streaming route gets a chance to run.Type of Change
Bug fix / stabilization hotfix.
Related Issue(s)
Related to #581.
Changes Made
autostatic-layout-first policy behind an explicit constant.autostarts the streaming native route first.Scope Note
This does not touch native helper binaries, CUDA source, packaged assets, timeline behavior, or the Windows 10 HUD/input issue. It addresses only the Lightning routing suspect from #581.
Testing Guide
Preparing export...and either runs the streaming native path or falls back normally.Checklist
origin/mainLocal Checks
npm test -- src/lib/exporter/backendPolicy.test.ts src/lib/exporter/modernVideoExporter.fallback.test.tsnpx tsc --noEmit --pretty falsenpx biome check --formatter-enabled=false src/lib/exporter/backendPolicy.ts src/lib/exporter/backendPolicy.test.ts src/lib/exporter/modernVideoExporter.ts src/lib/exporter/modernVideoExporter.fallback.test.tsgit diff --check(exit 0; Git emitted local LF-to-CRLF warnings only)Runtime/Repro Evidence
Not run in a packaged Windows build yet. This stays draft until Windows 10/11 packaged Lightning smoke confirms the route no longer stalls at
Prepare.Summary by CodeRabbit
New Features
Improvements
Tests