Issues with switched NPC( 'g' key)

[alisaad673]

while we press 'G' key and switch to the nearest NPC, I noticed following issues:

1- "E" activator keeps appearing over the npc, while we switch to it.

2022-07-28.18-58-47.mp4

2-The jump animation of switched npc is too fast.

2022-07-28.19-00-21.mp4

3-While we press "E" on the switched NPC, it restricts the movement of npc inside a kind of loop around the avatar.

2022-07-28.19-01-18.mp4

4-While we switch to npc from avatar, the avatar is left just in the state it was switched from.

2022-07-28.19-03-16.mp4

[avaer]

I think the bug is that avatar updates for switched-to NPCs are run twice.

[jakezira]

Solution

• When npc joins the party, it should be moved to avatar's app manager from scene app manager.
• Physics tracker needs to track all app manager including scene and avatar's. Actually, manager for physics tracking is preferable ==> Physics tracker manager #3614

Avatar Switching (G)

• You can only switch to avatar who already joined the party, not from npcs from the world.

[jakezira]

Party System

Related Pull Requests

• Implement player party system #3625
• Disable npc activate for new party system totum#130

Video

• https://www.loom.com/share/544739b353b540fc86cd38197d491833

Notes

• Fixed of all 4 bugs
• Party is up to 3 members, including the main character. When player activates the npc, it joins party.
• Party members follows a main character in a line, instead of all members heading to main character at the same time.
• Default avatar can't be removed from party.
  • Only npcs can be invited to and removed from the party.
  • We have fixed npc pool, and main avatar will not be added into npc pool.

Update

• Added party manager which changes the actions and collects the members
  • Added action api to party manager. Supported features are switchcharacter, addplayer and removeplayer.
  • Player class should have no idea about parties
• Removed dependency to avatar app on party manager

Test cases

• Open a scene, with at least 2 npcs.
• Activate one npc. See if it follows player.
• Deactivate the following character. See if it stops following.
• Activate another npc.
• Press G to swap to new character.
• Check if new character can interact with other character and npc.
• Activate another remaining npc.
• Run the player and see if all characters are following in a line.
• Keep switching characters.
• Do jump and switch to another character instantly. All characters should move smoothly.