feat(league): add conferences and divisions#38
Merged
Conversation
Owner
Author
|
I still need to review this PR pretty closely as there are a significant number of changes that went in here, but an initial test run of the CLI looks good to me. Opening for review. |
Owner
Author
whatsacomputertho
left a comment
whatsacomputertho
left a comment
There was a problem hiding this comment.
Multiple (mostly nitpick) comments for feedback
whatsacomputertho
added a commit
that referenced
this pull request
Feb 1, 2026
* feat(league): add conferences and divisions * feat(league): account for fbsim-core refactoring in league subcommands * feat(league): review and revise initial conferences & divisions impl * fix(format): remove newlines, proper imports and comments * fix(duplicate): check for duplicate conf and div teams before adding * fix(build): rebuild and regenerate manifest and lock * chore(deps): use fbsim-core main branch
whatsacomputertho
added a commit
that referenced
this pull request
Feb 1, 2026
* feat(league): add conferences and divisions * feat(league): account for fbsim-core refactoring in league subcommands * feat(league): review and revise initial conferences & divisions impl * fix(format): remove newlines, proper imports and comments * fix(duplicate): check for duplicate conf and div teams before adding * fix(build): rebuild and regenerate manifest and lock * chore(deps): use fbsim-core main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I add an initial implementation of conferences and divisions across various
fbsimCLI commands.fbsim league season conference- Commands for adding conferences to leagues and viewing conferencesfbsim league season conference division- Commands for adding divisions to conferences and viewing divisionsVarious existing commands are also updated to account for the possibility that footballsim leagues may now contain various different combinations of conferences & divisions.
For reference, see: