todo service

Author: linyuan.yang

packages/app/src-tauri/icons/icon.icns

@@ -515,17 +515,14 @@ class Config {
   getAgentSkillsPath(agentName: string) {
     return this.getConfigPath(`agents/${agentName}/skills`, true)
   }
-  getSessionSkillsPath(dbSessionId: string) {
-    return this.getConfigPath(`sessions/${dbSessionId}/skills`, true)
-  }
   getAgentInsightsPath(agentName: string) {
     return this.getConfigPath(`agents/${agentName}/insights`, true)
   }
-  getSessionInsightsPath(dbSessionId: string) {
-    return this.getConfigPath(`sessions/${dbSessionId}/insights`, true)
+  getSessionInsightsPath(sessionId: string) {
+    return this.getConfigPath(`sessions/${sessionId}/insights`, true)
   }
-  getSessionTodoPath(dbSessionId: string) {
-    return this.getConfigPath(`sessions/${dbSessionId}/todos.json`)
+  getSessionTodoPath(sessionId: string) {
+    return this.getConfigPath(`sessions/${sessionId}/todos.json`)
   }
   getAgentMcpServers(agentName: string): MCPServers {
     const mcpConfigPath = this.getConfigPath(`agents/${agentName}/mcp.json`);

packages/sbot/src/Core/Config.ts

@@ -45,7 +45,8 @@ export class InsightExtractor implements IInsightExtractor {
             const { results } = await this.modelService.invokeStructured<{ results: ExtractedInsight[] }>(InsightExtractionSchema, messages);
             return results;
         } catch (error: any) {
-            this.logger?.warn(`Insight extraction failed: ${error.message}`);
+            const detail = error?.response?.data ? ` body=${JSON.stringify(error.response.data)}` : '';
+            this.logger?.warn(`Insight extraction failed: ${error.message}${detail}`);
             return [];
         }
     }

packages/scorpio.ai/src/Insight/Extractor/InsightExtractor.ts

@@ -53,7 +53,8 @@ export class OpenAIModelService implements IModelService {
 
   async invokeStructured<T = any>(schema: any, prompt: string | ChatMessage[], options?: { signal?: AbortSignal }): Promise<T> {
     const input = typeof prompt === 'string' ? prompt : toBaseMessages(prompt);
-    return this.model!.withStructuredOutput(schema).invoke(input, options?.signal ? { signal: options.signal } : undefined) as Promise<T>;
+    const structured = this.model!.withStructuredOutput(schema, { method: "functionCalling" });
+    return structured.invoke(input, options?.signal ? { signal: options.signal } : undefined) as Promise<T>;
   }
 
   async stream(messages: string | ChatMessage[], options?: { signal?: AbortSignal }): Promise<AsyncIterable<ChatMessage>> {

packages/scorpio.ai/src/Model/OpenAIModelService.ts

@@ -54,7 +54,8 @@ export class TodoExtractor implements ITodoExtractor {
             );
             return actions;
         } catch (error: any) {
-            this.logger?.warn(`Todo extraction failed: ${error.message}`);
+            const detail = error?.response?.data ? ` body=${JSON.stringify(error.response.data)}` : '';
+            this.logger?.warn(`Todo extraction failed: ${error.message}${detail}`);
             return [];
         }
     }

packages/scorpio.ai/src/Todo/Extractor/TodoExtractor.ts

@@ -25,23 +25,27 @@ export class TodoService implements ITodoService {
         @inject(ILoggerService, { optional: true }) loggerService?: ILoggerService,
     ) {
         this.logger = loggerService?.getLogger("TodoService");
+        this.logger?.debug(`TodoService initialized: filePath=${filePath}, extractor=${!!extractor}`);
     }
 
     getToolDescs(): TodoToolDescs {
         return this.toolDescs;
     }
 
     async list(filter?: TodoListFilter): Promise<Todo[]> {
+        this.logger?.debug(`list called: filter=${JSON.stringify(filter ?? {})}`);
         const data = await this.read();
         const status = filter?.status ?? TodoStatus.Pending;
         let items = data.todos;
         if (status !== 'all') items = items.filter(t => t.status === status);
         if (filter?.priority) items = items.filter(t => t.priority === filter.priority);
-        return items.sort((a, b) => {
+        const result = items.sort((a, b) => {
             const dp = PRIORITY_ORDER[a.priority] - PRIORITY_ORDER[b.priority];
             if (dp !== 0) return dp;
             return a.createdAt.localeCompare(b.createdAt);
         });
+        this.logger?.debug(`list result: total=${data.todos.length}, filtered=${result.length}`);
+        return result;
     }
 
     async formatForLLM(filter?: TodoListFilter): Promise<string> {
@@ -59,14 +63,19 @@ export class TodoService implements ITodoService {
     }
 
     async extractFromConversation(userMessage: string, assistantMessages?: string[]): Promise<void> {
-        if (!this.extractor) return;
+        if (!this.extractor) {
+            this.logger?.debug(`extractFromConversation skipped: no extractor configured`);
+            return;
+        }
+        this.logger?.debug(`extractFromConversation start: userMsgLen=${userMessage.length}, assistantMsgs=${assistantMessages?.length ?? 0}`);
         try {
             const data = await this.read();
             const actions = await this.extractor.extract(
                 userMessage,
                 assistantMessages ?? [],
                 data.todos,
             );
+            this.logger?.debug(`extractor returned ${actions.length} action(s)`);
             if (actions.length === 0) return;
 
             for (const a of actions) {
@@ -106,6 +115,7 @@ export class TodoService implements ITodoService {
             }
 
             await this.write(data);
+            this.logger?.debug(`extractFromConversation done: applied ${actions.length} action(s)`);
         } catch (error: any) {
             this.logger?.error(`Todo extraction failed: ${error.message}`);
         }
@@ -115,12 +125,17 @@ export class TodoService implements ITodoService {
         try {
             const buf = await fsp.readFile(this.filePath, 'utf-8');
             const parsed = JSON.parse(buf) as Partial<TodoFile>;
-            return {
+            const file = {
                 todos: Array.isArray(parsed.todos) ? parsed.todos : [],
                 nextId: typeof parsed.nextId === 'number' ? parsed.nextId : 1,
             };
+            this.logger?.debug(`read: ${file.todos.length} todo(s), nextId=${file.nextId}`);
+            return file;
         } catch (e: any) {
-            if (e.code === 'ENOENT') return { todos: [], nextId: 1 };
+            if (e.code === 'ENOENT') {
+                this.logger?.debug(`read: file not found at ${this.filePath}, returning empty`);
+                return { todos: [], nextId: 1 };
+            }
             this.logger?.warn(`Failed to read todos at ${this.filePath}: ${e.message}; returning empty`);
             return { todos: [], nextId: 1 };
         }
@@ -133,6 +148,7 @@ export class TodoService implements ITodoService {
         try {
             await fsp.writeFile(tmp, JSON.stringify(data, null, 2), 'utf-8');
             await fsp.rename(tmp, this.filePath);
+            this.logger?.debug(`write: ${data.todos.length} todo(s), nextId=${data.nextId} -> ${this.filePath}`);
         } catch (e) {
             await fsp.unlink(tmp).catch(() => {});
             throw e;