-
Notifications
You must be signed in to change notification settings - Fork 51
Description
I had latitude and longitude values that placed me right next to Manila, Philippines, but for some reason, citipy would return Santa Monica as the nearest city. Even though there is a Santa Monica in the Philippines, it is some 100+ miles away from Manila.
If you want to look into the citipy error I encountered, you can try to recreate it yourself:
lat = 15.325736570808928
lng = 120.73129576518153
print(f"{citipy.nearest_city(lat, lng).city_name}")
When I run this, it returns santa monica. Notice that Santa Monica, Philippines is located at approximately (10.12651, 126.04144). Off by about 5 degrees in both latitude and longitude. Citipy does not work as expected here, and I imagine it is due to some flaw in the data set that citipy is based off of. I haven't tested very many other data points and checked, because it's rather time consuming.
I checked the csv, and line 32940 has the following:
ph,santa monica,15.35771,120.72006
This is incorrect, unless google maps' location data cannot be trusted, which is how I verified this. Not sure if you want to make an explicit change to the csv itself considering you probably reload that data every so often, but I wanted to note this error. Perhaps it can be forwarded up the line.