Skip to content

fix: block unsafe sudo auto install and prevent doctor from rewriting… #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wnlen merged 1 commit into from
Apr 29, 2026
Merged

fix: block unsafe sudo auto install and prevent doctor from rewriting… #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ source "$PROJECT_DIR/scripts/init/systemd-user.sh"
source "$PROJECT_DIR/scripts/init/script.sh"

init_project_context "$PROJECT_DIR"
guard_unsafe_sudo_auto_install "${1:-}"
load_env_if_exists
migrate_env_legacy_compat_fields "$PROJECT_DIR/.env"
detect_install_scope "${1:-auto}"
ensure_project_not_wsl_windows_mount

Expand Down
38 changes: 32 additions & 6 deletions scripts/core/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,6 @@ ensure_project_not_wsl_windows_mount() {
}

load_env_if_exists() {
local env_file
env_file="$PROJECT_DIR/.env"

if [ -f "$PROJECT_DIR/.env" ]; then
set -a
# shellcheck disable=SC1090
Expand All @@ -299,7 +296,6 @@ load_env_if_exists() {
fi

normalize_env_compat
cleanup_env_legacy_compat_fields "$env_file"
}

normalize_env_compat() {
Expand Down Expand Up @@ -346,12 +342,15 @@ normalize_env_compat() {
return 0
}

cleanup_env_legacy_compat_fields() {
migrate_env_legacy_compat_fields() {
local file="$1"
local tmp

[ -n "${file:-}" ] || return 0
[ -f "$file" ] || return 0

tmp="$(mktemp "${file}.tmp.XXXXXX")" || return 0

awk '
$0 ~ /^[[:space:]]*(export[[:space:]]+)?BUILD_MIN_SUCCESS_SOURCES=/ { next }
$0 ~ /^[[:space:]]*(export[[:space:]]+)?CLASH_SUBSCRIPTION_FORMAT=/ { next }
Expand All @@ -360,7 +359,23 @@ cleanup_env_legacy_compat_fields() {
next
}
{ print }
' "$file" > "${file}.tmp" && mv "${file}.tmp" "$file"
' "$file" > "$tmp" || {
rm -f "$tmp" 2>/dev/null || true
return 0
}

if cmp -s "$file" "$tmp"; then
rm -f "$tmp" 2>/dev/null || true
return 0
fi

if [ ! -w "$file" ]; then
rm -f "$tmp" 2>/dev/null || true
warn ".env 当前用户不可写，已跳过兼容迁移：$file"
return 0
fi

mv -f "$tmp" "$file"
}

github_proxy_prefix() {
Expand Down Expand Up @@ -1116,6 +1131,17 @@ ensure_openwrt_install_supported() {
fi
}

guard_unsafe_sudo_auto_install() {
local requested="${1:-}"

if [ "$(id -u)" -eq 0 ] \
&& [ -n "${SUDO_USER:-}" ] \
&& { [ -z "${requested:-}" ] || [ "$requested" = "auto" ]; }; then
die_state "检测到未受支持的安装方式：sudo bash install.sh" \
"普通安装请执行：bash install.sh；系统级安装请显式执行：sudo bash install.sh system"
fi
}

detect_install_scope() {
local requested="${1:-auto}"

Expand Down
Loading