Update modal

[Guido07111975]

Hi,

Just saw there's an update (nice) and I clicked the View Details link.
I notice FX Builder is using the default WP modal, which displays WP-focussed information. So it's confusing and sometimes even wrong info.

The modal of other CP plugins looks like this:

[wolffe]

Well, I am passing that information for CP only (see below), so I guess the modal displays it, in a wrong way. I assume the "WordPress" string needs to be changed to "ClassicPress" in Core.

[Guido07111975]

Guess @xxsimoxx know how this works?
Perhaps something to do with your own update thing, instead of the one from the CP Directory?

[xxsimoxx]

Yes, it's from it's own update code.
But I can't see the "View details" link.

[wolffe]

The only reason I'm using my own update code is that I have statistics.

Also, because it's the same code I am using for all my premium WordPress plugins and it's working flawlessly. It's a very small file, with no dependencies. Way better than other solutions out there, such as Freemius or Andy Fragen's Git Updater.

[Guido07111975]

This also means it's not possible to use the CP-focussed modal?

[wolffe]

This also means it's not possible to use the CP-focussed modal?

Correct.

The native ClassicPress updater works really well with my other plugin - W3P SEO.

I might remove my custom one from FX Builder at some point, maybe when it gets more traction. I'll keep it for now.

[Guido07111975]

Difference between both plugins is the header Update URI: https://getbutterfly.com > that's why FX Builder does not get its updates via the CP Directory, right?

When looking at the headers you posted earlier:
To make the WP focussed modal display the correct info, you should change requires and tested into 6.2, because both are WP headers. This will fix:

Requires WordPress Version: 2.0 or higher
Compatible Up to WordPress Version: 2.6.0

[Guido07111975]

Or requires into an older WP version, if supported of course (like 4.9).

[wolffe]

You are correct. It's the header that points the updater to mine.

Also, I can change those, but I would rather change these strings in Core, if I can find them, and submit a PR:

Requires WordPress Version to Requires ClassicPress Version
Compatible Up to WordPress Version to Compatible Up to ClassicPress Version

EDIT: And I found the lines here:

https://github.com/ClassicPress/ClassicPress/blob/854b96f22670117b44ba449e4cb3c94bf3f93c7b/src/wp-admin/includes/plugin-install.php#L704

[Guido07111975]

But the modal is for WP plugins, so it's correct!
Somehow your plugin is using the WP modal, I guess because you're not using the CP Directory update mechanism.

Or requires into an older WP version, if supported of course (like 4.9).

And tested can also be a higher version than (WP) 6.2, if supported.

To be clear: requires and tested are WP-headers. So should contain WP info.

[wolffe]

At some point, WordPress compatibility will diverge, and lots of WP plugins won't be compatible with CP. So this modal is, for the moment, a deprecated feature.

Also, as this is not a breaking code issue, I will leave it like this.

Like I said, I might switch to the native CP updater once FX Builder gets more traction.

[Guido07111975]

If you simply change both WP headers to contain WP values, the modal will display correct info.
Maybe @xxsimoxx knows how to make the plugin use the CP modal?

[xxsimoxx]

Don't know how to use the CP modal.
Requires at least and Tested up to are for WP, so better using WP's values.