Skip to content

"InnerMaxHeight" not found #1

@Abe101

Description

@Abe101

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-skewable-view@0.0.2 for the project I'm working on.

Found an issue with "InnerMaxHeight" not found. So the variable was not declared but assigned a value out of the blue. What I found further was that this wasn't being used anywhere so I thought its okay if it were to be gone unless its supposed to be used somewhere else.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-skewable-view/SkewableView.js b/node_modules/react-native-skewable-view/SkewableView.js
index e77eb79..f7c2dc4 100644
--- a/node_modules/react-native-skewable-view/SkewableView.js
+++ b/node_modules/react-native-skewable-view/SkewableView.js
@@ -60,7 +60,6 @@ export default class SkewableView extends Component {
             } else {
                 renderable = false;
             }
-            innerMaxHeight = innerHeight;
             innerHeight = innerHeight * Math.cos(angleRad) - innerWidth/2 * Math.tan(angleRad);
             innerHeight = Math.floor(innerHeight);
             translateX = -(innerWidth-this.props.boundingBoxWidth)/2;

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions