Skip to content

Remove _validate_no_mutations from ParallelStage fan-in #1099

@xbrianh

Description

@xbrianh

_validate_no_mutations in gremlins/stages/parallel.py raises NotImplementedError when a parallel child has committed or dirtied its worktree during a review. This crashes the gremlin with an unhandled exception rather than a clean bail.

The check was apparently a placeholder for a not-yet-implemented fan-in merge, but mutating parallel children (e.g. reviewer agents) is a valid use case. Remove the method and the call to it in _do_fan_in.

Location: gremlins/stages/parallel.py:525-556

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions