BinaryClient returns null instead of error output when deleting non-existent resource

[kstekovi]

Problem Description

When using OpenShifts.adminBinary().execute() to delete a non-existent resource, the method returns null instead of the actual error message from the oc command.

Expected Behavior

When executing oc delete kafkatopic abc on a non-existent resource manually, the command outputs an error message such as:

Error from server (NotFound): kafkatopics.kafka.strimzi.io "abc" not found

Actual Behavior

When the same command is executed via XTF's OpenShifts.adminBinary(namespace).execute("delete", "kafkatopic", "abc"), the method returns null instead of the error message.

Reproduction

Test Code:

@Test
public void testDeleteNonExistentKafkaTopic() {
    LOG.info("Attempting to delete non-existent Kafka topic: {}", TOPIC_NAME);
    
    String result = OpenShifts.adminBinary(NAMESPACE).execute("delete", "kafkatopic", TOPIC_NAME);
    
    LOG.info("Delete command result: {}", result);  // Logs: "Delete command result: null"
}

Manual execution:

$ oc delete kafkatopic abc
Error from server (NotFound): kafkatopics.kafka.strimzi.io "abc" not found

Impact

This makes it difficult to properly handle error cases in tests, as there's no way to distinguish between:

• Successful deletion (returns null)
• Resource not found (returns null)
• Other errors (returns null)

Expected Fix

The BinaryClient.execute() method should return the error output from stderr when the command fails, similar to how manual oc command execution works.

[mchoma]

Null comes from here

xtf/core/src/main/java/cz/xtf/core/openshift/CLIUtils.java

Line 95 in bc2cbf5

return null;

Because command return 1 and goes to this code branch

xtf/core/src/main/java/cz/xtf/core/openshift/CLIUtils.java

Line 86 in bc2cbf5

} else {

Changing this method could affect current users of this method. So probable there must be created another method with different standard behaviour which would fit your need - if I understand correctly method that returns output on success nad error stream on error.

Note, I doubt Successful deletion (returns null) is true. When successful deletion happens, command returns 0 and I assume output is correctly returned.

[kstekovi]

A specification doesn't exist so we can't say what is correct. But i think there should exist parity between XTF CLI utility and CLI command and it should behave the same way. especially when then XTF CLI utility is logging command output from stderr into console but return null instead of the message.

So I think it is clear bug in behavior.