Skip to content

scripts/check_em_dash.py never scans .yml/.yaml files #343

Description

@yakew7

Where: scripts/check_em_dash.py:24:

SCAN_EXT = {".md", ".py", ".js", ".html", ".css"}

The gap: YAML is never scanned at all, even though the repo's own em-dash-free convention is meant to apply repo-wide (CONTRIBUTING.md's style rule isn't scoped to specific file types). Two tracked .yml files already contain a real em dash, un-flagged by CI: .github/ISSUE_TEMPLATE/new_audit.yml and .github/ISSUE_TEMPLATE/new_explainer.yml (both use it inside a checkbox label demonstrating the banned character itself - the same legitimate reason CONTRIBUTING.md is already in ALLOWLIST).

Suggested fix: add .yml/.yaml to SCAN_EXT, and add those two issue-template files to ALLOWLIST alongside CONTRIBUTING.md, with the same justification comment (they're intentionally demonstrating the banned character, not violating the rule).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions