Skip to content

MCP server's proxy_hints tool has no held_out equivalent to --proxy-hints-with #348

Description

@yakew7

Where: faircode/mcp_server.py's _proxy_hints_impl (around line 127) and its @server.tool() wrapper.

faircode/proxy.py's proxy_hints() already accepts an optional held_out: dict | None parameter (added for issue #328 - lets a caller test a protected attribute that's already been dropped from the dataset, "we dropped the column so it's fine"), and faircode/cli.py's --proxy-hints-with PATH=COLUMN flag already wires this up end-to-end for the CLI. The MCP tool never passes held_out through at all - an agent calling proxy_hints via MCP has no way to reach this capability, even though it's fully implemented one layer down.

Suggested fix: add a held_out-equivalent parameter to the MCP proxy_hints tool (e.g. a {column: {path, column}}-shaped argument, or a simpler held_out_with: list[str] of "PATH=COLUMN" strings mirroring the CLI flag exactly, reusing cli._build_held_out's validation logic rather than re-implementing it).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions