Skip to content

Web profiler's Compare tool has no "Advanced thresholds" panel, unlike the Profile tool and the CLI #351

Description

@yakew7

Where: profiler.html's Compare section (~lines 279-325) vs. its single-dataset Profile section (~lines 227-253).

The single-dataset Profile view has a full <details id="thresholdsBlock">" "Advanced thresholds" panel wired via [data-opt]attributes inassets/profiler-ui.jstomin_share/intersection_floor/imbalance_flag/missing_flag/min_group_size(added in #284). The Compare section has a "Column mapping" panel but no threshold panel at all, andassets/profiler-compare.js's maybeCompare()` calls:

var cmp = E.compare(E.profile(slot.A.table, currentOverrides),
                     E.profile(slot.B.table, currentOverrides), ...)

passing only currentOverrides to E.profile(), never a third opts argument - even though profile(table, overrides, opts) accepts one and the CLI's `compare" subcommand already exposes all five threshold flags.

Why it matters: of the three surfaces this profiler ships (CLI, web Profile, web Compare), Compare is the only one where a user can't adjust thresholds like min_share or min_group_size before checking for drift - they're stuck with the defaults.

Suggested fix: add the same threshold-input panel used in the Profile view to the Compare view, threading the resulting opts object through maybeCompare()'s two E.profile() calls, mirroring how currentOverrides is already threaded through today.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions