Skip to content

Makefile's top comment doesn't mention favicons.yml among the CI workflows it mirrors #401

Description

@yakew7

Where: Makefile, top-of-file comment:

# Fair Code - contributor task runner.  See CONTRIBUTING.md.
# Reproduces locally what CI runs (.github/workflows: audits.yml, lint.yml,
# build-explainers.yml) so you can catch failures before you push.

The gap: the comment names three workflows this Makefile mirrors, but make favicons mirrors the newer .github/workflows/favicons.yml (not listed), and make fix-explainer-count has no CI mirror mentioned either even though scripts/check_explainer_count.py is wired into build-explainers.yml.

Why it matters: minor, but it's the exact kind of "doc comment wasn't updated when the feature landed" drift this repo otherwise polices closely (see the several CODEOWNERS/README-tree issues from this same audit pass).

Suggested fix: update the comment to .github/workflows: audits.yml, lint.yml, build-explainers.yml, favicons.yml.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationgood first issueGood for newcomershelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions