From 0658e147e50a58ed2b3f92feabe0eba36f4abf28 Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Thu, 30 May 2024 11:12:02 -0700 Subject: [PATCH 1/2] work_serializer_dispatch debug --- src/core/lib/experiments/rollouts.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/lib/experiments/rollouts.yaml b/src/core/lib/experiments/rollouts.yaml index fe679a5718e49..d719ab3047798 100644 --- a/src/core/lib/experiments/rollouts.yaml +++ b/src/core/lib/experiments/rollouts.yaml @@ -111,7 +111,6 @@ - name: work_serializer_clears_time_cache default: true - name: work_serializer_dispatch - requires: ["event_engine_client"] default: # TODO(ysseung): Not fully tested. ios: broken From efc0eec2954d44d4d59c9fb3a17ad52e42d62053 Mon Sep 17 00:00:00 2001 From: yousukseung <85715732+yousukseung@users.noreply.github.com> Date: Thu, 30 May 2024 18:22:47 +0000 Subject: [PATCH 2/2] Automated change: Fix sanity tests --- bazel/experiments.bzl | 2 +- src/core/lib/experiments/experiments.cc | 15 +++------------ 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl index 8dffc68bf2125..0a345c89bce41 100644 --- a/bazel/experiments.bzl +++ b/bazel/experiments.bzl @@ -43,7 +43,7 @@ EXPERIMENT_ENABLES = { "trace_record_callops": "trace_record_callops", "unconstrained_max_quota_buffer_size": "unconstrained_max_quota_buffer_size", "work_serializer_clears_time_cache": "work_serializer_clears_time_cache", - "work_serializer_dispatch": "event_engine_client,work_serializer_dispatch", + "work_serializer_dispatch": "work_serializer_dispatch", "call_v3": "call_v3,event_engine_client,event_engine_listener,work_serializer_dispatch", } diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc index 8fc435e0f24ca..bcaedb6d91aa4 100644 --- a/src/core/lib/experiments/experiments.cc +++ b/src/core/lib/experiments/experiments.cc @@ -129,8 +129,6 @@ const char* const description_work_serializer_dispatch = "callback, instead of running things inline in the first thread that " "successfully enqueues work."; const char* const additional_constraints_work_serializer_dispatch = "{}"; -const uint8_t required_experiments_work_serializer_dispatch[] = { - static_cast(grpc_core::kExperimentIdEventEngineClient)}; const char* const description_call_v3 = "Promise-based call version 3."; const char* const additional_constraints_call_v3 = "{}"; const uint8_t required_experiments_call_v3[] = { @@ -208,8 +206,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, - required_experiments_work_serializer_dispatch, 1, false, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, false, true}, {"call_v3", description_call_v3, additional_constraints_call_v3, required_experiments_call_v3, 3, false, false}, }; @@ -323,8 +320,6 @@ const char* const description_work_serializer_dispatch = "callback, instead of running things inline in the first thread that " "successfully enqueues work."; const char* const additional_constraints_work_serializer_dispatch = "{}"; -const uint8_t required_experiments_work_serializer_dispatch[] = { - static_cast(grpc_core::kExperimentIdEventEngineClient)}; const char* const description_call_v3 = "Promise-based call version 3."; const char* const additional_constraints_call_v3 = "{}"; const uint8_t required_experiments_call_v3[] = { @@ -402,8 +397,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, - required_experiments_work_serializer_dispatch, 1, false, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, false, true}, {"call_v3", description_call_v3, additional_constraints_call_v3, required_experiments_call_v3, 3, false, false}, }; @@ -517,8 +511,6 @@ const char* const description_work_serializer_dispatch = "callback, instead of running things inline in the first thread that " "successfully enqueues work."; const char* const additional_constraints_work_serializer_dispatch = "{}"; -const uint8_t required_experiments_work_serializer_dispatch[] = { - static_cast(grpc_core::kExperimentIdEventEngineClient)}; const char* const description_call_v3 = "Promise-based call version 3."; const char* const additional_constraints_call_v3 = "{}"; const uint8_t required_experiments_call_v3[] = { @@ -596,8 +588,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, - required_experiments_work_serializer_dispatch, 1, true, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, true, true}, {"call_v3", description_call_v3, additional_constraints_call_v3, required_experiments_call_v3, 3, false, false}, };