Skip to content

🎨 Polish: Improve connection status clarity#685

Open
yuga-hashimoto wants to merge 1 commit into
mainfrom
polish/connection-status-color-4762078492531532447
Open

🎨 Polish: Improve connection status clarity#685
yuga-hashimoto wants to merge 1 commit into
mainfrom
polish/connection-status-color-4762078492531532447

Conversation

@yuga-hashimoto
Copy link
Copy Markdown
Owner

💡 What

Modified StatusIndicator text label to dynamically change color depending on the current ConnectionState.

🎯 Why

Previously, the StatusIndicator label text used a static text color (MaterialTheme.colorScheme.onSurface) regardless of the connection state, even though the pulsing dot changed color. Applying semantic colors (Green for Connected, surface variant for Connecting, and error red for Disconnected) directly to the label text provides more immediate, clearer visual feedback to the user regarding their connection status, especially when skimming the settings or status overlays.

📸 Before/After

Before: Text label was always onSurface (usually white or black).
After: Text label is Color(0xFF4CAF50) when connected, onSurfaceVariant when connecting, and error when disconnected.

♿ Accessibility

This improvement reinforces the visual state communicated by the pulsing dot, offering an additional vector of information (text color) for users navigating connection states, adhering closer to WCAG recommendations for avoiding reliance on single visual cues (like just a colored dot) by combining it with semantically colored text.


PR created automatically by Jules for task 4762078492531532447 started by @yuga-hashimoto

Modified the `StatusIndicator` component to use semantic colors for the status label. Connected displays green, Connecting uses the standard variant, and Disconnected displays error red. This provides immediate visual feedback matching the semantic state, improving accessibility and overall UX clarity without altering the core app design language.

Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant