Rename the bitcoind-era public test-framework API to Z3 names#111
Rename the bitcoind-era public test-framework API to Z3 names#111dannywillems wants to merge 1 commit into
Conversation
20412ea to
9bb158e
Compare
The RPC test framework descends from Bitcoin Core via zcashd and kept the
inherited "bitcoind" naming even though the node under test is now zebrad.
Rename the misleading public names framework-wide for clarity:
BitcoinTestFramework -> ZcashTestFramework
bitcoind_processes -> node_processes
wait_bitcoinds -> wait_nodes
Also clarify the node-related comments, docstrings and a loop variable in
the framework (e.g. "Start a bitcoind" -> "Start a node", "Wait for all
bitcoinds to cleanly exit" -> "Wait for all nodes to cleanly exit").
Left unchanged on purpose: copyright headers ("The Bitcoin Core
developers"), references to external projects (python-bitcoinrpc, bitcoinj,
bitcoinlib), the ZCASHD_BINARY constant used by not-yet-migrated EXTENDED
tests, and the already-accurate node-generic names (start_node/start_nodes,
connect_nodes).
Builds on the internal-helper rename (zebrad_binary/wait_for_zebrad_start).
Verified locally: getmininginfo.py and nuparams.py still pass.
8192c97 to
d39716b
Compare
|
Reviewed this mechanically — compiled all 129 changed files (all parse) and swept the whole repo for each renamed symbol. Clean rename, with one miss: Breaks
Two-line fix ( Nit: Everything else checks out — Suggestion: grep the whole repo (not just On timing — since this rewrites the same core files as the in-flight #56 and #104, it might be cleanest to land those first and rebase this on top (the rename is trivially regenerable), so the functional PRs don't eat the conflicts. No strong opinion, just a sequencing thought. |
Feel free to close if you disagree with the renaming - don't lose much time reading if it is contraversary, I don't have a strong opinion. This is an automated patch generated by Claude in the background while onboarding on the code.
Closes #110. Builds on #108 (stacked: base is
chore/rename-node-helpers;retarget to
mainonce #108 merges).The test framework descends from Bitcoin Core via zcashd and kept the
inherited naming even though the node under test is
zebrad. This renamesthe widely-used public API for clarity:
BitcoinTestFramework->ZcashTestFrameworkbitcoind_processes->node_processeswait_bitcoinds->wait_nodesPlus node-related comments, docstrings, and a loop variable in the
framework (e.g. "Start a bitcoind" -> "Start a node").
Mechanical, repo-wide rename (~129 files). Left unchanged on purpose:
copyright headers ("The Bitcoin Core developers"), references to external
projects (python-bitcoinrpc, bitcoinj, bitcoinlib), the
ZCASHD_BINARYconstant used by not-yet-migrated EXTENDED tests, and the already-accurate
node-generic names (
start_node/start_nodes,connect_nodes).Verified locally: all files parse and
getmininginfo.py/nuparams.pystill pass.