-
-
Notifications
You must be signed in to change notification settings - Fork 13
deprecate password_prompt kwarg to OP() #119
Copy link
Copy link
Open
Labels
deprecationwork to be done to deprecate & remove some part of the APIwork to be done to deprecate & remove some part of the APIrefactorrefactoring work that isn't an enhancementrefactoring work that isn't an enhancement
Metadata
Metadata
Assignees
Labels
deprecationwork to be done to deprecate & remove some part of the APIwork to be done to deprecate & remove some part of the APIrefactorrefactoring work that isn't an enhancementrefactoring work that isn't an enhancement
We need to deprecate and plan to remove the
password_promptkwarg for theOP()constructor.Originally the purpose of this kwarg was:
OP_SESSION_<token>set from previously authenticating,opcommand to prompt for authentication on the console, or just fail hard?Now that authentications paths have gotten more complex (bio/no bio, service accounts, etc), and we have the
existing_auth=kwarg, allowing the caller to specify "use if available", "ignore", or "required", thepassword_promptpreference doesn't make any sense.We should do the following:
_new_or_existing_signin()and_do_normal_signin()where it gets used to rely exclusively onexisting_authOP()password_promptis passed in asTrue, either adjustexisting_author possibly raise an exception if the values conflict