Bug: RequiredLevel does not work like it should

[it2c]

Current Behaviour

Hello

I'm having some trouble with this module. I'm running on the playerbots base so Im not 100% sure that is the problem. When changing the MountRequirements.Riding.*.RequiredLevel to something else then the default the game does not pick up the change.

This is the config of the mod:
MountRequirements.Riding.Apprentice.BuyPrice = 40000
MountRequirements.Riding.Apprentice.RequiredLevel = 5

MountRequirements.Riding.Journeyman.BuyPrice = 500000
MountRequirements.Riding.Journeyman.RequiredLevel = 20

This is the result in the console debug logging:

MountRequirements: Apprentice Riding buy price: 40000
MountRequirements: Journeyman Riding buy price: 500000
MountRequirements: Expert Riding buy price: 2500000
MountRequirements: Artisan Riding buy price: 50000000
MountRequirements: Apprentice Riding required level: 5
MountRequirements: Journeyman Riding required level: 20
MountRequirements: Expert Riding required level: 40
MountRequirements: Artisan Riding required level: 60

When looking in the code it seems that there is an override of the table "npc_trainer".
This is also correctly reflected in the database:

ID;SpellID;MoneyCost;ReqSkillLine;ReqSkillRank;ReqLevel;ReqSpell
202010;33388;40000;762;0;5;0

No joy in game however, when visiting a mount trainer the required level for Apprentice is still marked at "20" (the default). Also, I did clear my cache ;-)

Upon further inspection in the database I did find another table "trainer_spell" that also contains mount level requirements for the riding skill spells.

That table is not updated by the module:

TrainerId;SpellId;MoneyCost;ReqSkillLine;ReqSkillRank;ReqAbility1;ReqAbility2;ReqAbility3;ReqLevel;VerifiedBuild
35;33388;40000;762;0;0;0;0;20;0
36;33388;40000;762;0;0;0;0;20;0
37;33388;40000;762;0;0;0;0;20;0
38;33388;40000;762;0;0;0;0;20;0
39;33388;40000;762;0;0;0;0;20;0
40;33388;40000;762;0;0;0;0;20;0
41;33388;40000;762;0;0;0;0;20;0
42;33388;40000;762;0;0;0;0;20;0
43;33388;40000;762;0;0;0;0;20;0
44;33388;40000;762;0;0;0;0;20;0
45;33388;40000;762;0;0;0;0;20;0
46;33388;40000;762;0;0;0;0;20;0

When I change the values in the "ReqLevel" collumn manually to "5", then clear my cache, I do in fact see the changes in game :-)

I'm not that fluent with coding, so could this please be looked at?

Expected Behaviour

When setting RequiredLevel this change should be visible in game (after clearing client cache).

Steps to reproduce the problem

1. Install module
2. Set RequiredLevel for any riding skill to something else then default
3. Clear client cache
4. See in game that the ReqLevel change is not changed

Extra Notes

See also table "trainer_spell" which contains riding skill level requirements.

AC rev. hash/commit

AC> AzerothCore rev. 8b0c82c3147d 2026-01-30 21:54:26 +0100 (Playerbot branch) (Unix, RelWithDebInfo, Static)
Connected players: 0. Characters in world: 0.
Connection peak: 0.
Server uptime: 2 hour(s) 1 minute(s) 26 second(s)
Update time diff: 1ms. Last 500 diffs summary:
|- Mean: 5ms
|- Median: 1ms
|- Percentiles (95, 99, max): 14ms, 15ms, 15ms
Using SSL version: OpenSSL 3.5.4 30 Sep 2025 (library: OpenSSL 3.5.4 30 Sep 2025)
Using Boost version: 1.83.0
Using CMake version: 3.31.6
Using MySQL version: 80408
Found MySQL Executable: /usr/bin/mysql
Compiled on: Linux 6.12.57+deb13-amd64
Worldserver listening connections on port ****
Realmlist (Realm Id: 2) configured in port ****
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in ./maps. Total size: 291014951 bytes
vmaps directory located in ./vmaps. Total size: 657797442 bytes
mmaps directory located in ./mmaps. Total size: 2192760616 bytes
Default DBC locale: enUS.
All available DBC locales: enUS koKR frFR zhCN
Using World DB: ACDB 335.15-dev
Using Playerbots DB Revision:
Latest LoginDatabase update: 2025_07_24_00.sql
Latest CharacterDatabase update: playerbots_names.sql
Latest WorldDatabase update: playerbots_rpg_races.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
PlayerbotsDatabase queue size: 0
List of enabled modules:
|- mod-ah-bot-plus
|- mod-aoe-loot
|- mod-guild-zone-system
|- mod-guildhouse
|- mod-junk-to-gold
|- mod-mount-requirements
|- mod-no-hearthstone-cooldown
|- mod-player-bot-level-brackets
|- mod-playerbots
|- mod-quick-respawn
|- mod-starter-guild

Operating system

debian 13 x64

Custom changes or Modules

No response

[Kurisuti99]

Changes Made

I updated three files in mod-mount-requirements.

These changes address the issue where riding skill settings were written to npc_trainer, but not to trainer_spell. On some AzerothCore configurations, including the Playerbots branch, the game appears to use trainer_spell for the riding trainer’s displayed and enforced requirements.

1. MountRequirements.h

Added two new function declarations for updating the trainer_spell table:

std::string BuildTrainerSpellUpdateQuery(const std::vector<uint32> ids, const uint32 buy, const uint32 level);
std::string BuildTrainerSpellUpdateQuery(const uint32 id, const uint32 buy, const uint32 level);

These were added beside the existing BuildSpellUpdateQuery declarations. The original functions remain responsible for updating npc_trainer.

---

2. MountRequirements.cpp

Added support for updating trainer_spell

Added the following two functions:

std::string MountRequirements::BuildTrainerSpellUpdateQuery(const uint32 id, const uint32 buy, const uint32 level)
{
    return MountRequirements::BuildTrainerSpellUpdateQuery(std::vector<uint32>{id}, buy, level);
}

std::string MountRequirements::BuildTrainerSpellUpdateQuery(const std::vector<uint32> ids, const uint32 buy, const uint32 level)
{
    std::string entriesCSV = VectorToCSV(ids);
    std::string sql = "UPDATE trainer_spell SET "
        "`MoneyCost` = " + std::to_string(buy) + ", "
        "`ReqLevel` = " + std::to_string(level) + " "
        "WHERE `SpellId` IN (" + entriesCSV + ")";
    return sql;
}

The existing BuildSpellUpdateQuery functions were left unchanged and continue updating npc_trainer. The original implementation only generated an UPDATE npc_trainer query.

Added trainer_spell updates when applying custom requirements

Added matching BuildTrainerSpellUpdateQuery calls for:

• Apprentice Riding
• Journeyman Riding
• Expert Riding
• Artisan Riding
• Cold Weather Flying

The completed section now updates both npc_trainer and trainer_spell:

// Set Requirements for Riding Skills
trans->Append(BuildSpellUpdateQuery(ApprenticeRidingTrainerSpellID,  ApprenticeRidingSkillBuyPrice,  ApprenticeRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(JourneymanRidingTrainerSpellID,  JourneymanRidingSkillBuyPrice,  JourneymanRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(ExpertRidingTrainerSpellID,      ExpertRidingSkillBuyPrice,      ExpertRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(ArtisanRidingTrainerSpellID,     ArtisanRidingSkillBuyPrice,     ArtisanRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(ColdWeatherFlyingTrainerSpellID, ColdWeatherFlyingSkillBuyPrice, ColdWeatherFlyingSkillRequiredLevel));

trans->Append(BuildTrainerSpellUpdateQuery(ApprenticeRidingTrainerSpellID,  ApprenticeRidingSkillBuyPrice,  ApprenticeRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(JourneymanRidingTrainerSpellID,  JourneymanRidingSkillBuyPrice,  JourneymanRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(ExpertRidingTrainerSpellID,      ExpertRidingSkillBuyPrice,      ExpertRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(ArtisanRidingTrainerSpellID,     ArtisanRidingSkillBuyPrice,     ArtisanRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(ColdWeatherFlyingTrainerSpellID, ColdWeatherFlyingSkillBuyPrice, ColdWeatherFlyingSkillRequiredLevel));

trans->Append(BuildItemUpdateQuery(TomeOfColdWeatherFlightItemID, TomeOfColdWeatherFlightBuyPrice, TomeOfColdWeatherFlightSellPrice, TomeOfColdWeatherFlightRequiredLevel));

The original apply function only called BuildSpellUpdateQuery for the riding skills.

Added trainer_spell updates when restoring original requirements

Added matching restore calls so disabling the module restores both trainer tables:

// Restore Original Requirements for Riding Skills
trans->Append(BuildSpellUpdateQuery(ApprenticeRidingTrainerSpellID,  OriginalApprenticeRidingSkillBuyPrice,  OriginalApprenticeRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(JourneymanRidingTrainerSpellID,  OriginalJourneymanRidingSkillBuyPrice,  OriginalJourneymanRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(ExpertRidingTrainerSpellID,      OriginalExpertRidingSkillBuyPrice,      OriginalExpertRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(ArtisanRidingTrainerSpellID,     OriginalArtisanRidingSkillBuyPrice,     OriginalArtisanRidingSkillRequiredLevel));
trans->Append(BuildSpellUpdateQuery(ColdWeatherFlyingTrainerSpellID, OriginalColdWeatherFlyingSkillBuyPrice, OriginalColdWeatherFlyingSkillRequiredLevel));

trans->Append(BuildTrainerSpellUpdateQuery(ApprenticeRidingTrainerSpellID,  OriginalApprenticeRidingSkillBuyPrice,  OriginalApprenticeRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(JourneymanRidingTrainerSpellID,  OriginalJourneymanRidingSkillBuyPrice,  OriginalJourneymanRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(ExpertRidingTrainerSpellID,      OriginalExpertRidingSkillBuyPrice,      OriginalExpertRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(ArtisanRidingTrainerSpellID,     OriginalArtisanRidingSkillBuyPrice,     OriginalArtisanRidingSkillRequiredLevel));
trans->Append(BuildTrainerSpellUpdateQuery(ColdWeatherFlyingTrainerSpellID, OriginalColdWeatherFlyingSkillBuyPrice, OriginalColdWeatherFlyingSkillRequiredLevel));

trans->Append(BuildItemUpdateQuery(TomeOfColdWeatherFlightItemID, OriginalTomeOfColdWeatherFlightBuyPrice, OriginalTomeOfColdWeatherFlightSellPrice, OriginalTomeOfColdWeatherFlightRequiredLevel));

The original restore section only restored npc_trainer.

Added missing break; statements

Added break; after every case in AppendMiscMountUpdate:

switch (m.RequiredSkillRank)
{
    case APPRENTICE_RIDING_SKILL_RANK:
        t->Append(BuildItemUpdateQuery(m.ItemID, apprMountBuyPrice, apprMountSellPrice, apprMountReqLevel));
        break;

    case JOURNEYMAN_RIDING_SKILL_RANK:
        t->Append(BuildItemUpdateQuery(m.ItemID, jourMountBuyPrice, jourMountSellPrice, jourMountReqLevel));
        break;

    case EXPERT_RIDING_SKILL_RANK:
        t->Append(BuildItemUpdateQuery(m.ItemID, exprMountBuyPrice, exprMountSellPrice, exprMountReqLevel));
        break;

    case ARTISAN_RIDING_SKILL_RANK:
        t->Append(BuildItemUpdateQuery(m.ItemID, artiMountBuyPrice, artiMountSellPrice, artiMountReqLevel));
        break;

    default:
        break;
}

Previously, the cases had no break; statements, which allowed the switch to fall through into the following riding ranks.

Added protection against an empty override query

Added:

if (overrides.empty())
    return overrides;

before the item_template lookup in GetOverridenMountsInfo.

This prevents the module from potentially generating a query containing:

WHERE entry IN ()

when the override configuration is present but contains no valid entries. The database query is created in this section of the original file.

---

3. MountRequirementsConfigLoader.cpp

Added:

MiscMountsData.clear();

at the beginning of LoadMiscMountsData:

void MountRequirements::LoadMiscMountsData()
{
    MiscMountsData.clear();

    std::istringstream mountBackupDataStream(MountBackupData);
    std::string mountData;

    while (std::getline(mountBackupDataStream, mountData))
    {
        if (mountData.empty())
            continue;

        MiscMountsData.push_back(MountInfo::fromCSV(mountData));
    }
}

This prevents duplicate entries from being added to MiscMountsData if the configuration is loaded more than once. The original function repeatedly used push_back without clearing the existing vector.

---

Files Modified

MountRequirements.cpp
MountRequirements.h
MountRequirementsConfigLoader.cpp

No changes were made to:

mount_requirements_loader.cpp
MountRequirementsScript.cpp
OriginalMountRequirements.h

Testing Status

These changes have been saved but still need to be:

1. Compiled with AzerothCore.
2. Tested for compilation errors.
3. Tested in-game with custom riding prices and required levels.
4. Verified in both npc_trainer and trainer_spell.
5. Tested with the module disabled to confirm the original values are restored.

Change MountRequirements.h.txt to MountRequirements.h before using it.
MountRequirements.h.txt
MountRequirements.cpp
MountRequirementsConfigLoader.cpp