Issue
Having the review council skill run procedural activities that would normally run in CI needlessly burns LLM context and tokens for something that can be reported more cheaply otherwise and that should already block a PR or release.
Suggested Resolution
Remove all instructions to execute items that the CI system will run automatically. Do identify areas where test jobs may have been hooked up locally but have not actually been correctly connected to the CI/CD framework. Common targets include Makefiles, Taskfiles, etc... but are not limited to those.
Repeating code in CI/CD configurations instead of using the inbuilt Makefile/Testfile/etc... should be flagged as a test finding since it creates a maintenance burden and is likely to create churn between CI and local development resolution.
We should take care to ensure that we do not over-index on specific technologies.
Issue
Having the review council skill run procedural activities that would normally run in CI needlessly burns LLM context and tokens for something that can be reported more cheaply otherwise and that should already block a PR or release.
Suggested Resolution
Remove all instructions to execute items that the CI system will run automatically. Do identify areas where test jobs may have been hooked up locally but have not actually been correctly connected to the CI/CD framework. Common targets include Makefiles, Taskfiles, etc... but are not limited to those.
Repeating code in CI/CD configurations instead of using the inbuilt Makefile/Testfile/etc... should be flagged as a test finding since it creates a maintenance burden and is likely to create churn between CI and local development resolution.
We should take care to ensure that we do not over-index on specific technologies.