Skip to content

CRAP delta reporting in Review Council (Group 2c) #7

Description

@jflowers

Summary

Add a change-impact section to gaze-reporter.md that computes and reports CRAP score deltas between the base and PR branches as part of the Review Council review.

RFC: https://github.com/orgs/unbound-force/discussions/483 — Group 2c
Phase: 2 (Accessibility)

Context

The Review Council already uses gaze-reporter.md to analyze code quality. This enhancement adds a dedicated section that shows how CRAP scores changed for functions touched in the PR.

Implementation

Change-Impact Section in gaze-reporter.md

  • Compute CRAP scores on the base branch and the PR branch
  • Diff the scores for all functions touched in the PR
  • Present as a table: function name, base CRAP, PR CRAP, delta, verdict
  • Highlight functions that crossed thresholds (improved past or degraded past)

Verdict Integration

  • CRAP improvements contribute to a positive review signal
  • CRAP degradations trigger warnings or change requests
  • Net CRAP delta summarized in the review

Acceptance Criteria

  • gaze-reporter.md updated with a change-impact section
  • CRAP delta computed between base and PR branches
  • Per-function delta table included in review output
  • Functions crossing thresholds highlighted
  • Net CRAP delta summarized
  • Integrated into Review Council verdict logic

Dependencies

  • Depends on: Pre-change CRAP gate (Group 2b) — for changed-function identification
  • Related: divisor-entropy agent (Group 2a)
  • Repo: unbound-force

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High priority — Phase 1–2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions