From 3d12d95e1b80e781ed530516065db60e444be01d Mon Sep 17 00:00:00 2001
From: Valentine Frolov <thayornSwordsMan@gmail.com>
Date: Tue, 29 Sep 2026 10:34:50 +0300
Subject: [PATCH] fix(#1226): let local readers and object methods through the
 off-quota guard

---
 lib/fbe/octo.rb       |  1 +
 test/fbe/test_octo.rb | 47 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)

diff --git a/lib/fbe/octo.rb b/lib/fbe/octo.rb
index ee0ce178..e2dd0582 100644
--- a/lib/fbe/octo.rb
+++ b/lib/fbe/octo.rb
@@ -266,6 +266,7 @@ def with_disable_auto_paginate # rubocop:disable Layout/EmptyLineBetweenDefs
           intercepted(o) do |e, m, args, _r|
             next unless e == :before
             next if %i[off_quota? print_trace! rate_limit rate_limit!].include?(m)
+            next if %i[last_response auto_paginate per_page].include?(m) || Object.method_defined?(m)
             next if m == :get && %w[/rate_limit rate_limit].include?(args.first)
             if Fbe::SEARCH_METHODS.include?(m)
               raise(Fbe::OffQuota, "We are off-quota on the search resource, can't do #{m}()") if
diff --git a/test/fbe/test_octo.rb b/test/fbe/test_octo.rb
index 9efa8b8a..facde9a0 100644
--- a/test/fbe/test_octo.rb
+++ b/test/fbe/test_octo.rb
@@ -1672,4 +1672,51 @@ def test_fake_workflow_run_always_has_status
       refute_nil(result[:repository], "for workflow run #{id}")
     end
   end
+
+  def test_reads_last_response_when_off_quota
+    assert_equal(200, drained.last_response.status, 'paid response is not readable off quota')
+  end
+
+  def test_reads_paging_settings_when_off_quota
+    o = drained
+    assert_equal([true, 100], [o.auto_paginate, o.per_page], 'paging settings are not readable off quota')
+  end
+
+  def test_asks_object_methods_when_off_quota
+    seed = Random.new_seed
+    m = %i[nil? inspect class frozen? hash to_s].sample(random: Random.new(seed))
+    refute_nil(drained.__send__(m), "#{m} is refused off quota, seed #{seed}")
+  end
+
+  def test_dont_ask_quota_for_local_call
+    WebMock.disable_net_connect!
+    calls = 0
+    stub_request(:get, 'https://api.github.com/rate_limit').to_return do
+      calls += 1
+      { body: '{"rate":{"remaining":4000}}', headers: { 'Content-Type' => 'application/json' } }
+    end
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'github_token' => '' }))
+    o.per_page
+    assert_equal(0, calls, 'quota is asked for a local call')
+  end
+
+  def test_still_refuses_api_call_when_off_quota
+    assert_raises(Fbe::OffQuota, 'api call is made off quota') { drained.commits('foo/bar') }
+  end
+
+  private
+
+  def drained
+    WebMock.disable_net_connect!
+    stub_request(:get, 'https://api.github.com/rate_limit').to_return(
+      body: '{"rate":{"remaining":51}}',
+      headers: { 'Content-Type' => 'application/json', 'X-RateLimit-Remaining' => '51' }
+    )
+    stub_request(:get, %r{https://api.github.com/repos/foo/bar/commits}).to_return(
+      body: '[{"sha":"a1"}]', headers: { 'Content-Type' => 'application/json', 'X-RateLimit-Remaining' => '49' }
+    )
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'github_token' => '' }))
+    o.commits('foo/bar', per_page: 1)
+    o
+  end
 end