From 023b6c93bd62fb7b129d6ddb3a6fc23b92706da0 Mon Sep 17 00:00:00 2001
From: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com>
Date: Fri, 29 May 2026 09:34:22 +0200
Subject: [PATCH] test(api_remote): rename second-send test to carry
 _roundtrip_ substring
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR #132 added `second_send_succeeds_without_prev_commitment_pubkey_field`
as the fourth mutating roundtrip in `node/tests/api_remote.rs`, but its
name did not contain the `_roundtrip_` substring relied on by
`deploy-prd.yaml`'s `--skip _roundtrip_` filter. The PRD api-e2e job
therefore executed this mutating test against the live PRD node, where
it produced a 422 "Unable to get merkle proofs for provided public key"
because the scanner had not yet ingested the test's send-#1 commit
inscription on a slow Mainnet block-time when send-#2 fired.

Rename to `second_send_roundtrip_succeeds_without_prev_commitment_pubkey_field`
so the test name conforms to the established `<flow>_roundtrip_<assertion>`
pattern used by `mint_roundtrip_lands_balance_and_proof` and
`send_commit_roundtrip_moves_balance`. This restores the substring-filter
contract: every name with `_roundtrip_` mutates publisher UTXOs and the
PRD SMT/MMR, every name without it is read-only.

Also update the live-server-analogue cross-reference in the unit test
docstring at `node/src/account_node_tests.rs:774`. The unit test itself
(`test_send_coins_second_send_succeeds_without_prev_commitment_pubkey`)
is not renamed — it is not under the substring-filter contract.

No behavioural change. The test body, the wallet, and the workflow
`--skip` filter are unchanged.

Signed-off-by: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com>
---
 node/src/account_node_tests.rs | 2 +-
 node/tests/api_remote.rs       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/node/src/account_node_tests.rs b/node/src/account_node_tests.rs
index dfc5687e..bf78f3c1 100644
--- a/node/src/account_node_tests.rs
+++ b/node/src/account_node_tests.rs
@@ -771,7 +771,7 @@ fn test_send_coins_twice_from_same_account_uses_update_account() {
 /// `"prev_commitment_pubkey required for account update"`.
 ///
 /// Live-server analogue is the api_remote test
-/// `second_send_succeeds_without_prev_commitment_pubkey_field` —
+/// `second_send_roundtrip_succeeds_without_prev_commitment_pubkey_field` —
 /// this one drives the same code path through `account_node` directly
 /// (no prover, no HTTP) so the contract is pinned even when the
 /// `api_remote` suite is skipped (slim CI).
diff --git a/node/tests/api_remote.rs b/node/tests/api_remote.rs
index ce77ee52..0326ee0e 100644
--- a/node/tests/api_remote.rs
+++ b/node/tests/api_remote.rs
@@ -1954,7 +1954,7 @@ async fn balance_response_num_sends_starts_zero_and_bumps_on_send() {
 /// send #2 with `prev_commitment_pubkey` deliberately omitted →
 /// MUST succeed (AccountUpdate branch reads its own stored value).
 #[tokio::test]
-async fn second_send_succeeds_without_prev_commitment_pubkey_field() {
+async fn second_send_roundtrip_succeeds_without_prev_commitment_pubkey_field() {
     let client = http_client();
     let alice = TestWallet::new();
     let bob = TestWallet::new();