PDF with text plugin WIP

[jswhisperer]

https://github.com/jswhisperer/snapdom-plugin-fullpdf

[tinchox5]

Excellent!!

[jswhisperer]

Can't seem to get an npm login to publish

[jswhisperer]

If you want to leave some feedback would be awesome

[tinchox5]

Yes!!! I will play with your plugins ASAP thank you!

[tinchox5]

Hi @jswhisperer
I tried your plugin and it works great.

A few small ideas:

• One source file for the package (index.js or compiled TS only) so two entry files can’t drift apart.
• defineExports uses the key pdf and SnapDOM exposes toPdf() (their naming rule, not something extra in the plugin).
• Docs: keep the main readme to PDF-style options; tuck html2canvas details under “Advanced” or the html2pdf docs so it isn’t confused with SnapDOM’s own capture path.
• I’m also sharing a static HTML demo (no bundler): snapdom-fullpdf-static-demo.zip; serve the folder that contains both index.js and demo/.
• When you feel comfortable I would like to publish your plugin in snapdom.dev/plugins.html

Thanks again.

snapdom-fullpdf-static-demo.zip

[jswhisperer]

hey @tinchox5 I reckon it's closer now to your suggestions.
with the docs I'm not clear on how you would like them divided.

[jswhisperer]

got npm working https://www.npmjs.com/package/snapdom-html2pdf-plugin

[tinchox5]

hey @tinchox5 I reckon it's closer now to your suggestions.
with the docs I'm not clear on how you would like them divided.

I just suggested to omit
the html2canvas options because it may generate confusion since you are using snapdom.

And maybe you can simplify the plugin name, something like snap2pdf. And in defineexport you can simply put pdf so snapdom will convert to toPdf.

The flow is to use snap2pdf and then simply invoke it using.toPdf.

Again it is just a suggestion! You can maintain your original names no problem!!

[jswhisperer]

I like the name snap2pdf but I worry it will be confusing as there is a default toPdf solution in place?

[tinchox5]

You are right I never thought about that.

[jswhisperer]

Naming is probably the hardest thing in programming.

I'm open to any name tbh

[tinchox5]

He he you are right. But I will help you. I will prioritize plugin exporter name over core exporter. So, if a plugin use a core exporter name... for instance toPng, it will have priority. This way you can use toPdf() if you want

[jswhisperer]

I think that's a good move but honestly maybe better is deciding on a third party plugin naming scheme and adding to readme.

It could be whatever like prefix with snap or plugin etc to avoid naming conflicts