fix: resolve macOS tray click crash #4
Merged
+30
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use system_tray's AppWindow instead of window_manager for showing window on macOS to avoid nil pointer crash in WindowManager.swift - Set applicationShouldTerminateAfterLastWindowClosed to false to keep app running when minimized to tray - Save ref.listenManual() subscription to prevent GC
0Chencc
force-pushed
the
fix/macos-tray-crash
branch
from
bf79ea7 to
aebb4ab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 1 1
Lines 7 7
=======================================
Hits 5 5
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
system_tray'sAppWindow.show()instead ofwindow_managerto avoid nil pointer crashapplicationShouldTerminateAfterLastWindowClosedtofalseto keep app running when minimized to trayref.listenManual()subscription to prevent garbage collectionRoot Cause
window_managerpackage'sWindowManager.swift:60crashes with "Unexpectedly found nil while unwrapping an Optional value" when the window reference becomes invalid after hiding.Test plan